Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the Sandbox plugin on dev.newpathconsulting.com #358

Open
asirota opened this issue Sep 22, 2024 · 5 comments
Open

Using the Sandbox plugin on dev.newpathconsulting.com #358

asirota opened this issue Sep 22, 2024 · 5 comments
Assignees
Labels
Bug Something isn't working Playground plugin

Comments

@asirota
Copy link

asirota commented Sep 22, 2024

Getting this error when trying to use the Sandbox plugin on site dev.newpathconsulting.com

image

@asirota
Copy link
Author

asirota commented Sep 22, 2024

this needs to be moved to playground-tools I just realized :)

@bgrgicak bgrgicak transferred this issue from WordPress/wordpress-playground Oct 8, 2024
@bgrgicak bgrgicak moved this from Inbox to Needs Triage/Our Reply in Playground Board Oct 8, 2024
@bgrgicak
Copy link
Collaborator

bgrgicak commented Oct 8, 2024

Thank you for reporting this!

In my testing, it looks like the plugin is broken because of some changes Playground made to exporting.
When I open this page on a site with the Sandobox plugin installed: /wp-admin/tools.php?page=playground&download=1
It downloads a ZIP with PHP files and the database.

The ZIP file doesn't include WordPress files, only themes, plugins...
The blueprint responsible for starting a sandbox seems to expect a full WordPress zip and this is where my site failed to load.

To fix the plugin, we will need to rebuild the blueprint to work with the ZIP content.
The new directory resources could be a good fit for this.

@bgrgicak bgrgicak moved this from Needs Triage/Our Reply to Up next in Playground Board Oct 8, 2024
@bgrgicak bgrgicak added Bug Something isn't working Playground plugin labels Oct 8, 2024
@bgrgicak
Copy link
Collaborator

bgrgicak commented Oct 8, 2024

@adamziel this issue makes me wonder if we should even fix the plugin, or if we should remove it from WordPress.org until we can build a fully working version with the sync protocol. What do you think?

@bgrgicak bgrgicak moved this from Up next to Needs Triage/Our Reply in Playground Board Oct 8, 2024
@adamziel
Copy link
Collaborator

adamziel commented Oct 8, 2024

@bgrgicak I wouldn't mind that, but I just saw this:

Warning: Closing a plugin is intended to be a permanent action. There is no way to reopen a plugin without contacting the plugins team.

Let's keep the plugin in there, then, but replace the logic with a notice saying that it doesn't work at the moment, giving full context, and communicating we're going to be fixing it in short to medium term.

I'm thinking of moving that codebase to the core Playground repo maybe two weeks from now to have a central place for incubating all the PHP libraries.

@bgrgicak
Copy link
Collaborator

but replace the logic with a notice saying that it doesn't work at the moment, giving full context, and communicating we're going to be fixing it in short to medium term.

I can do both, the fix takes a few minutes, but there should also be a notice that the plugin is broken.

@bgrgicak bgrgicak self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Playground plugin
Projects
Status: Backlog
Development

No branches or pull requests

3 participants