You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're currently using Immutables interning for at least 3 types: Address, XAddress and XrpCurrencyAmount (all of which are in Wrappers in the model package).
Doing this causes a few issues:
Increased memory usage due to data that is both sparse and temporary in nature being long lived
We need to stop doing this. That said, this will cause backwards compatibility issues unless you have @Value.Immutable(builder = true) in your annotation (despite true being the default) as, at least in Wrappers, removing intern = true results in the builder() method disappearing.
The text was updated successfully, but these errors were encountered:
We're currently using Immutables interning for at least 3 types:
Address
,XAddress
andXrpCurrencyAmount
(all of which are inWrappers
in the model package).Doing this causes a few issues:
Map
key deserializer is not deterministic when there is no single arg constructor FasterXML/jackson-databind#3143We need to stop doing this. That said, this will cause backwards compatibility issues unless you have
@Value.Immutable(builder = true)
in your annotation (despitetrue
being the default) as, at least inWrappers
, removingintern = true
results in thebuilder()
method disappearing.The text was updated successfully, but these errors were encountered: