[AIE] Fixes https://github.com/Xilinx/llvm-aie/issues/174 #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martien-de-jong
requested review from
abhinay-anubola,
abnikant,
andcarminati,
F-Stuckmann,
gbossu,
katerynamuts,
khallouh,
konstantinschwarz,
niwinanto,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
khallouh
previously approved these changes
Jan 30, 2025
martien-de-jong
force-pushed
the
martien.fix-intrinsic-headers
branch
from
e28eae8 to
4203eb8
Compare
|
Can you update the commit message to a meaningful message? |
abnikant
reviewed
Jan 31, 2025
| @@ -23412,9 +23412,9 @@ msc_4x16_16x4_conf(v64bfloat16 a, v64bfloat16_sparse b, v16accfloat acc1, | |||
| a, b.data, b.mask, acc1, conf); | |||
| } | |||
| INTRINSIC(v16accfloat) | |||
| addmac_²4_conf(v64bfloat16 a, v64bfloat16_sparse b, v16accfloat acc1, | |||
| v16accfloat acc2, int zero_acc1, int sub_mul, int sub_acc1, | |||
| int sub_acc2) { | |||
There was a problem hiding this comment.
In the generator/generated code this is correct, not sure how/where it got changed.
martien-de-jong
force-pushed
the
martien.fix-intrinsic-headers
branch
from
4203eb8 to
21e1110
Compare
martien-de-jong
force-pushed
the
martien.fix-intrinsic-headers
branch
from
21e1110 to
65f05bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Fixes 174
I have edited a file that I shouldn't edit because it is generated. However, I can't imagine the generator would have made this one exceptional error, so I assume it got corrupted in transit somewhere.
I also made an pretty well informed, yet educated guess as to the correct name of this intrinsic.
@abnikant ?