Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Test events from the GitLab webhook edit page aren't styled #31

Open
dsevillamartin opened this issue May 26, 2018 · 7 comments
Open
Assignees
Labels

Comments

@dsevillamartin
Copy link
Member

From #28:

img

@dsevillamartin
Copy link
Member Author

dsevillamartin commented May 26, 2018

@noraj Can you look at the payload of the webhook and send it to me, here or through Discord? I cannot seem to reproduce this issue.

To look at the payload:

  1. Settings -> Integrations
  2. Click "Edit" button in webhook
  3. Click more details for Issue request

image

@noraj
Copy link
Contributor

noraj commented May 26, 2018

@datitisev I sent you details on private message on discord.

dsevillamartin added a commit that referenced this issue May 27, 2018
@dsevillamartin
Copy link
Member Author

@noraj I've pushed a change that may fix it. If you could resend the hook that was causing the bug, that'd be great. To do so, just go to the details view of my previous comment, and click "Resend".

@noraj
Copy link
Contributor

noraj commented May 28, 2018

I have still the same problem. Tell me if you need more info.

@dsevillamartin dsevillamartin self-assigned this May 28, 2018
@dsevillamartin
Copy link
Member Author

Root cause of this bug found. This occurs when you use the "Test" dropdown in the GitLab webhook edit page to test an event.
Instead of testing an actual event, for issues what it does is send the payload of a random issue.

@dsevillamartin dsevillamartin changed the title Some events don't have an action Some Test events from the GitLab webhook edit page aren't styled May 28, 2018
@dsevillamartin
Copy link
Member Author

Test Issue styled

image

@mutezero
Copy link

Testing merge_request has same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants