Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can i release the reproduction code ? #5

Open
HannH opened this issue Mar 28, 2020 · 4 comments
Open

Can i release the reproduction code ? #5

HannH opened this issue Mar 28, 2020 · 4 comments

Comments

@HannH
Copy link

HannH commented Mar 28, 2020

Hi, I rewrite the DMFN model from your paper since i cant wait to see it's result. I want to know if i have the right to release the code and write a blog about your algorithm?

@Zheng222
Copy link
Owner

@HannH Of course, welcome to release your reproduction code and post.

@HannH
Copy link
Author

HannH commented Mar 28, 2020

@HannH Of course, welcome to release your reproduction code and post.

I have released the code. But I'm not sure if align loss is writed in the right way. Could you check it?
the code is here
https://github.com/HannH/DMFN/blob/2ade61431e243734a9de54c9770856a6fca9ba8c/model/loss.py#L77

@Zheng222
Copy link
Owner

@HannH
https://github.com/HannH/DMFN/blob/2ade61431e243734a9de54c9770856a6fca9ba8c/model/loss.py#L84-L87
c_u_k = sum_u_v(self.coord_x * tar / sum_tar)

The values of meshgrid should be [-1, 1].

@phongnhhn92
Copy link

@HannH have u checked this ? I am trying to re-implement this as well. I wonder if your code is correct or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants