Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API bugs #76

Closed
4 of 7 tasks
fraknoiadam opened this issue Oct 20, 2023 · 1 comment · Fixed by #93
Closed
4 of 7 tasks

Fix API bugs #76

fraknoiadam opened this issue Oct 20, 2023 · 1 comment · Fixed by #93
Assignees
Labels
bug Something isn't working critical First priority to implement

Comments

@fraknoiadam
Copy link
Member

fraknoiadam commented Oct 20, 2023

There are a lot of bugs:

The following two bugs are also related to #97, so I make them complete here.

  • If someone has already started a game (and it is IN PROGRESS), you get an error and it stays in HOME. Expected behaviour: jump to the current game.
  • Strategy reset state api did not worked. It returns a new state, but not updates the teamstate
  • Admin endpoint reset-strategy is not working Create admin page #71
@fraknoiadam fraknoiadam added bug Something isn't working critical First priority to implement labels Oct 20, 2023
@fraknoiadam fraknoiadam changed the title Fix match start APIs Fix API bugs Oct 20, 2023
@OnionKiller
Copy link
Member

OnionKiller commented Jul 11, 2024

Also pls fix #77
#67 is also relevant here.

@OnionKiller OnionKiller linked a pull request Sep 30, 2024 that will close this issue
OnionKiller added a commit that referenced this issue Oct 2, 2024
* fix: fix issue in #76 with restarting game after finish

* fix: fix low effort fix

* fix: pagestate HOME not nescessarily means that game can be started

* chore: fomratting

* Update src/server/team_manage.ts

Co-authored-by: Ádám Fraknói <[email protected]>

---------

Co-authored-by: Ádám Fraknói <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical First priority to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants