-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add melange version of Promise (promise.js) #80
base: master
Are you sure you want to change the base?
Conversation
@@ -243,7 +238,7 @@ let soundnessTests = Framework.suite("soundness", [ | |||
|
|||
[@ocaml.warning "-33"] | |||
test("resolved: Almost-Promise-like", () => { | |||
let open Js_OO; | |||
/* let open Js_OO; */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commented this out since didn't seem needed, but wanted to acknowledge that I have no clue what's Js_OO
@@ -0,0 +1,3 @@ | |||
(library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ffi is a lib under test now, with the 2 separate versions
@@ -1,3 +1,3 @@ | |||
(library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The run file/lib isn't needed anymore since we can share framework
Fixes #79
This PR is a first attempt to migrate the promise version of previously builded from BuckleScript to Melange (and all of the related constraints).
I believe the change it's on a good direction since Melange enables sharing code and the original idea of this project seems to share the same interface between native and JS. If we want to keep the BuckleScript/ReScript version I could do a similar trick done in styled-ppx davesnx/styled-ppx#353
I vendor promise under server-reason-react here: https://github.com/ml-in-barcelona/server-reason-react/tree/main/packages/promise in order to enjoy the same experience as this library will provide (eventually will remove the vendor lib).
What are the changes:
[@bs.val]
(Melange don't need those)bs.*
intomel.*
modes melange
(wrapped false)
undertest/
to avoid changing the source-code.What hasn't been done:
Status
The proposition for this is to gather feedback about the changes and eventually release this as a new opam version.
Current test can be ran with: