Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N1: Improved Gas of ScaledBalanceTokenBase::_mintScaled() #758

Closed
miguelmtzinf opened this issue Dec 7, 2022 · 3 comments
Closed

N1: Improved Gas of ScaledBalanceTokenBase::_mintScaled() #758

miguelmtzinf opened this issue Dec 7, 2022 · 3 comments
Labels
auditor_Peckshield

Comments

@miguelmtzinf
Copy link
Contributor

Screenshot from 2022-12-07 09-52-55
@miguelmtzinf
Copy link
Contributor Author

This optimization is being discussed in #707 . This approach is used across the codebase in multiple functions. Changing the approach here, would imply to changing it everywhere and we agreed not to do it for now.

@eboadom
Copy link
Collaborator

eboadom commented Dec 15, 2022

Agree with @miguelmtzinf on this. I think a math refactoring will be done soon, but right now better to not create more asymmetries

@miguelmtzinf
Copy link
Contributor Author

Closing per comments above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auditor_Peckshield
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eboadom @miguelmtzinf