-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to remove speaker icon from tabs? #1
Comments
Hey, I'm glad you find it useful! I already wrote a response to your review on AMO. I'll paste it here again, because others might have the same question.
Edit:
|
I see you reopened this issue recently... does that mean you are taking a look into this? I have the same exact wish that the the creator of this issue has. I have been using chrome only because the mute icon isn't there or is disabled automatically. I would be using firefox as my main browser if it weren't for the mute button. Sometimes I have a lot of tabs open and it makes it quite difficult to avoid the mute button when clicking tabs. The option to disable the mute icon in about:config works but with all of the auto mute type addons they bring the icon back. I tried both of the userchrome.css ideas but neither of them work. |
I reopened this because the issue itself really isn't solved yet and closing it makes it harder for people to find the mentioned workaround. I'll eventually close it when Mozilla makes it possible to hide the speaker icon using WebExtensions. I don't know why the |
I don't use Windows, but that location doesn't look right. Can you try finding your profile folder as described in this article. The |
That helped me a lot, I used my search program and found the folder in question which was inside the firefox folder and I assumed it was the one I needed. The mute icon is gone which is a relief. Do I need to redo everything after each firefox update or does the css stay in place? Thanks by the way. |
No, as far as I know you won't have to redo it after every update. |
I added a tweak to the Tab Center Redux wiki to hide (not remove) the mute icons in that vertical tabs implementation. Also works for its pinned tabs. |
THANK YOU SO MUCH. |
However, the above hides the fact that the webpage intends/offers to play a sound. The following CSS only hides the icon for muted tabs that don't play sound. Then the "muted" icon gives us a visual clue (about sound available). The following also shows the "playing" icon. That is useful if, for example, earlier you were happy to unmute a tab, you switch to other tab(s), but later you want to mute that tab again and you want an indication in the tab bar (to find it easily, especially if you have many tabs).
@abba23 May I suggest linking https://addons.mozilla.org/en-US/firefox/addon/mute-sites-by-default to this issue, so that users can choose, please? |
All of the above suggestions work, but also hide the icon of the website, which is unsuitable. I don't have a solution, I don't even know if it's capable to address that with the tools Firefox gives us. But I wanted to make sure others knew. |
@KevinJRussell I posted a Firefox Support question about that issue, and the code at the bottom of the thread fixes that issue as long as you don't hover over the tab. However, as @peter-kehl pointed out in #11, it hides the site's intention of playing sound. |
That's not accurate. The code at the bottom of the thread hides the mute icon when sound isn't playing, but it also hides the website icon, which is unsuitable. I use those to identify tabs. |
@KevinJRussell Sorry, I forgot I modified that code to make it work properly. Here's the @namespace url(http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul);
.tab-icon-overlay[muted], .tab-icon-sound[muted], .tab-secondary-label[muted], .tab-icon-sound-muted-label {
display: none !important;
}
.tab-content, .tab-throbber[busy], .tab-icon-image {
opacity: 1.0 !important;
} The only issue is when you hover over the tab, the icon disappears, but hopefully it's better then nothing. If I can find a way to fix that, I'll post it in #11. |
This hides the mute button/icon, hides the muted label, keeps the site favicon, and puts a green border across the bottom to indicate a tab is unmuted. .tab-icon-overlay:not([soundplaying])[muted], .tab-secondary-label:not([soundplaying])[muted] {
display: none !important;
}
.tab-icon-stack[muted] > .tab-icon-image, .tab-icon-stack[muted] > .tab-throbber[busy]:hover {
opacity: initial !important;
}
tab:not([muted]) .tab-background {
border-bottom-width: 2px !important;
border-bottom-style: solid !important;
border-bottom-color: darkgreen !important;
} |
My config looks like this: My userChrome.css: .tab-icon-image {
opacity: 100 !important;
}
.tab-icon-overlay {
margin-top: 15px;
} In case firefox update their api: How to inspect firefox UI elements |
@josephcrowell Thank you very much! The best solution that keeps all functionalities. |
Dear abba23,
first of all - awesome extension :) I am really happy with it.
The only thing that happens to me from time to time - I mute / unmute a tab (especially when it is pinned), as the tabs get small. For this it would be great to include an option to remove the speaker icon from the tabs via an options menu!
Thanks for your consideration,
MMF
The text was updated successfully, but these errors were encountered: