Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement async room get spec #152

Closed
lawrence-forooghian opened this issue Nov 27, 2024 · 0 comments
Closed

Implement async room get spec #152

lawrence-forooghian opened this issue Nov 27, 2024 · 0 comments
Assignees
@lawrence-forooghian
Labels
room-lifecycle Related to room lifecycle (temporary label).

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Nov 27, 2024 •
edited
Loading

Split from #66.

Replace / implement spec points as described below.

  • CHA-RC1d (upon release, remove room from room map immediately) and CHA-RC1e (ordering of room removal from room map, RELEASE operation, completion of release() call) have been replaced by CHA-RC1f (async room fetch) and CHA-RC1g (replacement spec point for room release)
  • CHA-RC1a
    • Innocuous spec point that says that fetching a room gives you a room with that ID; replaced by CHA-RC1f (async room fetch)
  • CHA-RC1b, CHA-RC1c
    • Replaced by similar points under CHA-RC1f

┆Issue is synchronized with this Jira Task by Unito
@lawrence-forooghian lawrence-forooghian added the room-lifecycle Related to room lifecycle (temporary label). label Nov 27, 2024
@lawrence-forooghian lawrence-forooghian mentioned this issue Nov 27, 2024
Closed
lawrence-forooghian added a commit that referenced this issue Dec 3, 2024
@lawrence-forooghian
Implement “async room get”
23062c8 
That is, CHA-RC1f and CHA-RC1g.

Note that I’ve taken a slightly different approach to "one operation
waits for another" here than that which I took in the room lifecyle
manager. I’m using Task instances to represent the operation’s work
instead of using subscriptions; this new way feels easier to work with
and seems more intuitive, but I guess it means that I maybe create Tasks
where I wouldn’t need to otherwise; let’s see which we prefer working
with over time.

Resolves #152.
@coderabbitai coderabbitai bot mentioned this issue Dec 3, 2024
Merged
lawrence-forooghian added a commit that referenced this issue Dec 3, 2024
@lawrence-forooghian
Implement “async room get”
90f9c55 
That is, CHA-RC1f and CHA-RC1g.

Note that I’ve taken a slightly different approach to "one operation
waits for another" here than that which I took in the room lifecyle
manager. I’m using Task instances to represent the operation’s work
instead of using subscriptions; this new way feels easier to work with
and seems more intuitive, but I guess it means that I maybe create Tasks
where I wouldn’t need to otherwise; let’s see which we prefer working
with over time.

Resolves #152.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lawrence-forooghian lawrence-forooghian

Labels
room-lifecycle Related to room lifecycle (temporary label).
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lawrence-forooghian