Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-subscription history integration test is failing #167

Closed
lawrence-forooghian opened this issue Dec 2, 2024 · 2 comments
Closed

Pre-subscription history integration test is failing #167

lawrence-forooghian opened this issue Dec 2, 2024 · 2 comments
Labels
failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Dec 2, 2024 •
edited by sync-by-unito bot
Loading

Line 120 of IntegrationTests.swift has started failing:

try #require(rxMessagesBeforeSubscribing.items.count == 1)

Expectation failed: (rxMessagesBeforeSubscribing.items.count → 0) == 1

Not sure what's happened here.

┆Issue is synchronized with this Jira Task by Unito
@lawrence-forooghian lawrence-forooghian added the failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug. label Dec 2, 2024
@lawrence-forooghian
Copy link
Collaborator Author

Ah, @AndyTWF says this is due to a recent sandbox change that is going to be rolled back today.

@lawrence-forooghian
Copy link
Collaborator Author

Not sure if this one has been fixed or is just being masked by #169.

lawrence-forooghian added a commit that referenced this issue Dec 4, 2024
@lawrence-forooghian
Introduce a wait to work around history not being “live”
1cb8801 
(The integration tests are still failing, though, due to #169, but at
least they’re now failing in a consistent manner.)

Resolves #167.
@lawrence-forooghian lawrence-forooghian mentioned this issue Dec 4, 2024
Closed
lawrence-forooghian added a commit that referenced this issue Dec 4, 2024
@lawrence-forooghian
Introduce a wait to work around history not being “live”
e7e5e3b 
(The integration tests are still failing, though, due to #169, but at
least they’re now failing in a consistent manner.)

Resolves #167.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce a wait to work around history not being “live” ably/ably-chat-swift
1 participant
@lawrence-forooghian