Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ARTPushRegistererDelegate.didAblyPushRegistrationFail to ARTPushRegistererDelegate.didAblyPushUpdateFail #1169

Open
ben-xD opened this issue Aug 20, 2021 · 0 comments
Labels
code-quality Affects the developer experience when working in our codebase. enhancement New feature or improved functionality.

Comments

@ben-xD
Copy link
Contributor

ben-xD commented Aug 20, 2021

ARTPushRegistererDelegate is the delegate with 3 methods which are called back:

  • didActivateAblyPush: called when activate succeeds or fails
  • didDeactivateAblyPush: called when deactivate succeeds or fails
  • didAblyPushRegistrationFail: called when updating Ably with new details fails. The point is, it is only called when updating ably (in an internal method called callUpdateFailedCallback), and not during "registration"/ activation.

Additional, this is the same 3 APIs on Android, which are called. On Android, they are 3 intents which are created. The user has to listen to these:

  • io.ably.broadcast.PUSH_ACTIVATE
  • io.ably.broadcast.PUSH_DEACTIVATE
  • io.ably.broadcast.PUSH_UPDATE_FAILED

Therefore, to allow users to understand the API better and make it appear consistent with Android, we should rename this method ARTPushRegistererDelegate.didAblyPushRegistrationFail to ARTPushRegistererDelegate.didAblyPushUpdateFail

@umair-ably umair-ably added enhancement New feature or improved functionality. code-quality Affects the developer experience when working in our codebase. labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Affects the developer experience when working in our codebase. enhancement New feature or improved functionality.
Development

No branches or pull requests

2 participants