Respecting RSH8b - generate new local device's id and secret on push activation

[maratal]

RSH8b:

The LocalDevice id and deviceSecret attributes are generated, and persisted as part of the LocalDevice state, when required by step (RSH3a2b) in the Activation State Machine.

Specs state that device's id and deviceSecret should be created on event CalledActivate. Whereas current implementation creates them lazily in the ARTRest.device property.

More details here

Related to issue

┆Issue is synchronized with this Jira Task by Unito

[lawrence-forooghian]

This might require a breaking change to the library (making ARTDeviceDetails.id nullable), and hence require a major version bump. I still think it's a good thing to do, though.

[maratal]

This might require a breaking change to the library (making ARTDeviceDetails.id nullable), and hence require a major version bump. I still think it's a good thing to do, though.

Maybe nullable ARTDeviceDetails.id should be done here? #1259 WDYT @lawrence-forooghian

[lawrence-forooghian]

I think they can probably be done as separate things – we have no need to make it nullable for the solution of #1259, since in the solution #1259 there's never a moment when the device is in a "reset" state (i.e. it always has an id, secret, etc).

[maratal]

I think they can probably be done as separate things – we have no need to make it nullable for the solution of #1259, since in the solution #1259 there's never a moment when the device is in a "reset" state (i.e. it always has an id, secret, etc).

As I've stated some time ago here #1184 (comment) it's actually in a reset state until app relaunched.