Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the rest of swift concurrency annotations #1971

Closed
maratal opened this issue Sep 8, 2024 · 3 comments
Closed

Add the rest of swift concurrency annotations #1971

maratal opened this issue Sep 8, 2024 · 3 comments
Assignees
@maratal

Comments

@maratal
Copy link
Collaborator

maratal commented Sep 8, 2024 •
edited by sync-by-unito bot
Loading

Continuation of #1962

Some types were not added because it's not obvious what should be added from the glance. I suggest to keep this issue open and add types that causing compilation errors in this description (meanwhile adding them to Ably+Dependencies.swift to add them all at once later in ably-cocoa):

ARTRealtimePresenceQuery

┆Issue is synchronized with this Jira Task by Unito
@maratal maratal self-assigned this Sep 8, 2024
maratal added a commit to ably/ably-chat-swift that referenced this issue Sep 8, 2024
@maratal
Made ARTRealtimePresenceQuery sendable, because without it I get a …
3d9f6e2 
…compile time error (issue ably/ably-cocoa#1971):

```
Non-sendable type 'ARTRealtimePresenceQuery?' in parameter of the protocol requirement satisfied by actor-isolated instance method 'get(params:)' cannot cross actor boundary
```
@lawrence-forooghian
Copy link
Collaborator

If there are still types that we know need to be added, we should do this before doing a release.

@maratal maratal mentioned this issue Sep 12, 2024
Closed
@maratal
Copy link
Collaborator Author

maratal commented Sep 12, 2024

If there are still types that we know need to be added, we should do this before doing a release.

#1973

This was referenced Sep 20, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@maratal
Copy link
Collaborator Author

maratal commented Sep 26, 2024 •
edited
Loading

@umair-ably couldn't you post here screenshots of the warnings/errors with ARTRealtimeChannelOptions and ARTChannelProperties you've mentioned in this PR? I've also faced an error with the properties member in final class Channel: RealtimeChannelProtocol, but declaring it as a readonly getter solved the problem.

@maratal maratal mentioned this issue Sep 26, 2024
Open
This was referenced Sep 30, 2024
Closed
Closed
Closed
@sync-by-unito sync-by-unito bot closed this as completed Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maratal maratal

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ECO-4968] Added missed NS_SWIFT_SENDABLE ably/ably-cocoa
2 participants
@maratal @lawrence-forooghian