Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publish of presence messages does not respect maxMessageSize from ConnectionDetails #1960

Open
VeskeR opened this issue Jan 24, 2025 · 0 comments
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@VeskeR
Copy link
Contributor

VeskeR commented Jan 24, 2025

See https://sdk.ably.com/builds/ably/specification/main/features/#RSL1i and https://sdk.ably.com/builds/ably/specification/main/features/#TO3l8, presence actions should be checked for exceeding maxMessageSize just like regular messages here:

const size = getMessagesSize(wireMessages);
if (size > maxMessageSize) {
throw new ErrorInfo(
'Maximum size of messages that can be published at once exceeded ( was ' +
size +
' bytes; limit is ' +
maxMessageSize +
' bytes)',
40009,
400,
);
}

current behavior:
presence message which exceeds maxMessageSize is published and NACKed with Maximum message length exceeded

┆Issue is synchronized with this Jira Task by Unito

@VeskeR VeskeR added the bug Something isn't working. It's clear that this does need to be fixed. label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Development

No branches or pull requests

1 participant