-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reactor HTTP Endpoint changes breaks docs + tutorials #765
Comments
Yeah - traditional batched webhooks have their own custom structure https://www.ably.io/documentation/general/webhooks#example-channel-message different from all the other rules for historical reasons, and that structure doesn't take an enveloped option |
➤ Tony Bedford commented: (All) Tutorials will be addressed (eventually) as part of https://ably.atlassian.net/browse/DOC-593 ( https://ably.atlassian.net/browse/DOC-593|smart-link ) |
➤ Tony Bedford commented: {quote}When using in API Consumer, I think we should make it clear that batch request mode is not supported, as opposed to just hiding that option.{quote} Not sure what “API Consumer“ means, but both batch and single are now supported for all rule types. |
➤ Tony Bedford commented: I think webhooks docs (https://ably.com/documentation/general/events ( https://ably.com/documentation/general/events|smart-link )) have been updated since this was raised. |
➤ Tony Bedford commented: {quote}I am not sure it makes sense to put "Request Mode" under headers, when enveloped & encoding options sit below the source info. I think how the data is delivered should be grouped together.{quote} I’m not sure this is a docs issue. If there’s still a concern I can raise it with the Product team. |
➤ Tony Bedford commented: {quote}The help copy about how Envelopes works also needs to be revisited now{quote} Text now says: Messages delivered through Reactor are wrapped in an Ably envelope by default that contains metadata about the message and its payload. The form of the envelope depends on whether it is part of a Webhook/Function ( https://ably.com/general/events ) or a Queue/Firehose ( https://ably.com/documentation/general/queues#enveloped ) rule. For everything besides Webhooks, you can ensure you only get the raw payload by unchecking "Enveloped" when setting up the rule. We should not be using the term “Reactor“ (we have another ticket to address this), but I think otherwise the text is now OK isn’t it? |
➤ Tony Bedford commented: Closing, as I think all the items in this ticket have been addressed now. |
The new Reactor Integration work for IFTT, Zapier and Cloudflare has gone live. As part of this work, we also consolidated Webhooks & HTTP Custom Endpoints into just "HTTP Endpoint".
We have a number of issues now:
Whilst looking at this, we may additional want to consider:
┆Issue is synchronized with this Jira Bug by Unito
The text was updated successfully, but these errors were encountered: