Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl executive activity report charged page #1367

Open
wants to merge 20 commits into
base: dev
Choose a base branch
from
Open

impl executive activity report charged page #1367

wants to merge 20 commits into from

Conversation

wjeongchoi
Copy link
Contributor

@wjeongchoi wjeongchoi commented Jan 22, 2025 •
edited
Loading

요약 *

It closes #1358

/executive/activity-report/charged/[id] 구현

스크린샷

이후 Task *

@wjeongchoi wjeongchoi added new feature 새로운 기능을 추가하는 경우입니다 front-end labels Jan 22, 2025
@wjeongchoi wjeongchoi self-assigned this Jan 22, 2025
@wjeongchoi wjeongchoi linked an issue Jan 22, 2025 that may be closed by this pull request
Impl executive activity report charged page #1358
Open
2 tasks
@wjeongchoi wjeongchoi marked this pull request as ready for review January 26, 2025 13:12
@jooyeongmee
Copy link
Contributor

활보 작성 내역 페이지 > 담당자별 필터 > 테이블 행 클릭 > 활보 검토 내역 페이지로 이동 > 뒤로 가기 > 활보 작성 내역 페이지 동아리별 필터로 돌아옴
요렇게 흘러가는데 여기서 담당자별 필터로 테이블 행 클릭했으면 뒤로 가기 해서도 담당자별 필터를 유지하는게 편할거 같은데 어떻게 생각해? 라우팅 할 때 속성을 넣으면 될거 같은데🤔

jooyeongmee
jooyeongmee reviewed Feb 1, 2025
View reviewed changes
...src/features/executive/activity-report/components/_atomic/ActivityReportStatisticContent.tsx Outdated Show resolved Hide resolved
...ges/web/src/features/executive/activity-report/components/ActivityReportChargedClubTable.tsx Outdated
if (!a.commentedAt) return -1;
if (!b.commentedAt) return 1;
return (
new Date(b.commentedAt ?? b.updatedAt).getTime() -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 api response 데이터 중에 editedAt도 있던데 editedAt 와 updatedAt 가 무슨 차이가 있는지 알아?
지원금에서는 updatedAt 는 안 쓰고 editedAt을 써서 혹시나 싶어 확인하면 좋을거 같아요 (활보 상세페이지에서도 다 updatedAt 을 쓰고 있긴 하네)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updatedAt은 db 자체에서 뭔가 바뀌면 매번 바뀌는 타임스탬프고
editedAt은 작성자가 수정한 시각 / commentedAt은 집행부가 검토한 최종 시각

...ges/web/src/features/executive/activity-report/components/ActivityReportChargedClubTable.tsx Outdated Show resolved Hide resolved
...es/web/src/features/executive/activity-report/components/ActivityReportChargedOtherTable.tsx Outdated Show resolved Hide resolved
...ges/web/src/features/executive/activity-report/services/useGetExecutiveChargedActivities.tsx Outdated Show resolved Hide resolved
@wjeongchoi
Copy link
Contributor Author

활보 작성 내역 페이지 > 담당자별 필터 > 테이블 행 클릭 > 활보 검토 내역 페이지로 이동 > 뒤로 가기 > 활보 작성 내역 페이지 동아리별 필터로 돌아옴 요렇게 흘러가는데 여기서 담당자별 필터로 테이블 행 클릭했으면 뒤로 가기 해서도 담당자별 필터를 유지하는게 편할거 같은데 어떻게 생각해? 라우팅 할 때 속성을 넣으면 될거 같은데🤔

이거 새로고침 / breadcrumb 눌렀을 때는 초기화되긴 하는데 뒤로가기 해서 이동할 때는 유지되게 해놨어요

@wjeongchoi wjeongchoi mentioned this pull request Feb 2, 2025
Open
6 tasks
@jooyeongmee
Copy link
Contributor

LGTM 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jooyeongmee jooyeongmee jooyeongmee approved these changes

@babycroc babycroc Awaiting requested review from babycroc

Assignees

@wjeongchoi wjeongchoi

Labels
front-end new feature 새로운 기능을 추가하는 경우입니다
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Impl executive activity report charged page
2 participants
@wjeongchoi @jooyeongmee