Rule Editor: Keyboard navigation #38

JulienCochuyt · 2024-07-22T06:44:50Z

In the Rule Editor:

F6 should move focus between the category tree and the selected pane. In the category tree, focus should land on the selected item. In the selected pane, focus should land on the last focused element as long as the selected pane is not changed. When the selected pane is changed, focus should land on the first element.
control+(shift+)tab should alternatively select same level items of the category tree and loop. When eg. a level 2 item is selected, it should only loop between the level 2 items belonging to the same level 1 node. Focus should land on the first element of the selected pane.

The text was updated successfully, but these errors were encountered:

- `F6`: Switch focus between categories and content panel - `control[+shift]+tab`: Cycle through same level categories - `alt+{home|end}`: Focus first/last content panel control - Guard more wx event handlers

JulienCochuyt · 2024-08-04T17:33:48Z

Will be part of PR #21.

After testing, it appears that NVDA's MultiCategorySettingsDialog, when cycling through categories, sets focus on the control that had it last when returning to the same content panel - by simply focusing the panel itself.
Thus, adopted the same behavior on the new TreeMultiCategorySettingsDialog.

Also added:

alt+home / alt+end to focus the first/last control on the content panel.
F2 to move focus from the Properties Pane list to the editing field, and escape to move back to the list.

- `control+enter`: Validate the dialog, independantly of wheither the currently focused control handles `enter` in some way Follow-up of 7ba4e94

- WebModule Editor: Do not require a trigger when creating from the Rule Editor - WebModule Manager: Add key shortcuts `F2`, `F3` and `delete` to edit, manage rules and delete, respectively (#38) - WebModule Manager: Set "no" as the default when prompting for deletion - Refactor `gui.actions` into `gui.rule.actions` - Refactor `gui.criteriaEditor` into `gui.rule.criteriaEditor` - Refactor `gui.gestureBinding` into `gui.rule.gestureBinding` - Refactor `gui.properties` into `gui.rule.properties` - Refactor `gui.webModulesManager` into `gui.webModule.manager` - Refactor `gui.webModuleEditor` into `gui.webModule.editor` - Refactor `gui.webModuleManager.promptDelete` into `gui.webModule.promptDelete` - GUI: Refactor `gui.webModuleManager.promptMask` into `gui.webModule.promptMask`

Implement Overridden Properties and Actions for Criteria #21 - Bump format version to 0.9-dev - Bump API version to 0.5 - Alternative criteria sets now hold properties and actions - `Rule` and `Criteria` properties are now managed through their `properties` attribute - GUI: Rule Editor: New tree category selector: - Category nodes may have sub-nodes for fast editing of common fields - Pressing `space` on a sub-node toggles the field value (or focuses the field, depending on its type) - Pressing `delete` on a sub-node reverts the field value to its default - GUI: Fix several scaling issues - GUI: Drop support for older wxPython that was required for NVDA < 2018.3 - GUI: Rules Manager: Migrate use of deprecated `wx.TreeCtrl.[Get|Set]ItemPyData` - GUI: Criteria Editor: Rename the Criteria Set name field for easier UI discovery (#24) - Python 3: Replace lengthy Python 2 `super` calls * Refactor `TreeContextualPanel` and fix field labelling in "One Input" panel * Extract generic part and move it in `gui.__init__.py` * Rename specific part to `gui.ruleEditor.RuleEditorTreeContextualPanel` * Use dataclasses for `CategoryParams` * Remove value from the "One Input" field label * Fix some labels not being translatable * RuleEditor: PropertiesPanel: WIP on fixing the rendering of the edit controls * Free text fields still misbehave (upcoming properties spec refactoring) * Edit control still not shown if only one property is supported for the rule type * Re-arranged buttons on the CriteriaEditor PropertiesPanel * fix update tree refresh when criterion deleted or created * Utils: `guarded` decorator: Add doc and forward decorated func's doc and name * RulesManager: Guard wx event handlers * GUI: Do not store a Result in context pretending it's a Rule Had a hard time figuring this one out, left-over from early prototyping of multi-criteria. Was my bad, actually. * GUI: Remove backport of `SettingsPanelAccessible` from NVDA 2021.1 * RuleEditor: Keyboard navigation (#38) - `F6`: Switch focus between categories and content panel - `control[+shift]+tab`: Cycle through same level categories - `alt+{home|end}`: Focus first/last content panel control - Guard more wx event handlers * GUI: Make TreeMultiCategorySettingsDialog "fillable" Allow content panels to fill the whole available container height. * GUI: TreeMultiCategorySettingsDialog: Restore original code styling Aim is to reduce diff when comparing with original code from NVDA's MultiCategorySettingsDialog * RuleEditor: Keyboard navigation (#38) - Follow-up - `control+enter`: Validate the dialog, independantly of wheither the currently focused control handles `enter` in some way Follow-up of 7ba4e94 * Criteria Editor: Fix Criteria panel systematically exhibiting a horizontal scroll bar - Added new `gui.SizeFrugalComboBox` which does not request for additional width to accommodate the content of its drop-down. * Refactor UI and Properties - Centralize properties handling in `ruleHandler.properties` - Add `utils.logException` decorator to help diagnose issues in property getters - Extract rule agnostic portion of `gui.ruleEditor.ChildOneInputPanel` into `gui.SingleFieldEditorPanel` - Refactore `gui.shortcutDialog` into `gui.gestureBinding` and fix handling of editing existing gesture bindings - Document methods of `gui.ContextualSettingsPanel` and make it abstract - Move `gui.ruleEditor` to `gui.rule.editor` - Move `gui.rulesManager` to `gui.rule.manager` - Rule Editor: Fix updating of tree child nodes upon change - Rule Editor: Fix focus move upon change - Rule Editor: Fix list selection upon change - Rule Editor: Fix rule comment not being saved - Rule Editor: Fix handling of alternative deletion - Rule Editor: Fix handling of gesture binding deletion * GUI: GestureBinding: Don't send bare modifiers when capturing input Avoid triggering eg. Windows "Switch Keyboard Layout" shortcut when pressing `ctrl+shift`. * GUI: Actions: Fix broken save operation Fix-up of 24e005b * GUI: Editors: Notify errors upon saving * NodeHandler: Fix mouse move in Python 3 * Criteria Alternatives: Support overriding rule gestures Follow-up of feb09ce * Editors: Fix Criteria Summary re. Properties Fix-up of 24e005b * Criteria Alternatives: Fix handling of the "multiple" property when overridden * Properties: Fix "multiple" should not be allowed for zones Was a dev leftover from the `feature/subModules` branch * DataRecovery: Refactor modules into their own package * Bump format version to 0.9-dev Properties are only stored if they differ from the default value. Choice properties default to None. Text properties default to the empty string. These defaults may have been previously stored interchangeably. A None or empty value in a Criteria Property now overrides a defined value at Rule level. * Remove `ruleHandler.ruleTypes.RULE_TYPE_FIELDS` Superseded by `ruleHandler.properties.PropertySpec.ruleTypes` * Fix typo Fix-up of 0585603 * fix: ensure correct setting of formMode in RuleEditorDialog * fix(webAccess/gui/rule): correct default data type in AlternativesPanel's getData method * Addressed review action: fixup cbce52e See #21 (review) * fix: correct mutation property access in control mutation * Layers: Restore trigger override naming This "overrides" key at WebModule level really means "This WebModule overrides the trigger set and help content coming from a WebModule with the same key ref on an upper layer which can be found in another file, usually shipped with an addon." Not to be confused with overridden Rule properties at Criteria Alternative level - once called _overrides_ - despite the ambiguous _layered property_ naming at WebModule level. The former informs about what were the original values, the latter masks original values with new ones. Fix-up of c8422c6 * GUI: Editors: Fix displaying of custom action names Fix-up of 24e005b * Properties: Be more verbose when reporting errors * DataRecovery: Fix from 0.6-dev to 0.8-dev and from 0.8-dev to 0.9-dev * DataRecovery: Update batch recovery from 0.6-dev to 0.9-dev (was to 0.8-dev) * GUI: Avoid mistaking an unintentional ValueError for a meaningful ValidationError * GUI: Follow-up of NVDA #15121 - `gui.mainFrame._popupSettingsDialog` is deprecated as of NVDA 2023.2 - `gui.mainFrame.popupSettingsDialog` is now part of the public API * GUI: MultiCategory editors: Select the invalid panel's category upon validation failure * RuleEditor: Remove the apply button * remove useless condition in onCategroyChange * fix undefined data in editor onAutoActionChoice * Fix KeyError in `testCriteria(...)` by adding default to pop method * Rename module from 'recoverFrom_0_6_to_0_9' to 'from_0_6_to_0_9' in data recovery to fix "TypeError: 'module' object is not callable" --------- Co-authored-by: Sendhil RANDON <[email protected]> Co-authored-by: BOUYSSOU Gatien <[email protected]> Co-authored-by: Julien Cochuyt <[email protected]>

Implement Overridden Properties and Actions for Criteria #21 - Bump addon version to 2024.08.31 - Bump format version to 0.9-dev - Bump API version to 0.5 - Properties are only stored if they differ from the default value. Choice properties default to None. Text properties default to the empty string. These defaults may have been previously stored interchangeably. A `None` or empty value in a Criteria Property now overrides a defined value at Rule level. - Remove `ruleHandler.ruleTypes.RULE_TYPE_FIELDS` Superseded by `ruleHandler.properties.PropertySpec.ruleTypes` - Alternative criteria sets now hold properties and actions - Centralize properties handling in `ruleHandler.properties` - `Rule` and `Criteria` properties are now managed through their `properties` attribute - Zones: Support the "multiple" property - Refactore `gui.shortcutDialog` into `gui.gestureBinding` and fix handling of editing existing gesture bindings - Refactor `gui.ruleEditor` into `gui.rule.editor` - Refactor `gui.rulesManager` into `gui.rule.manager` - GUI: Rule Editor: New tree category selector: - Category nodes may have sub-nodes for fast editing of common fields - Keyboard shortcuts (#38): - `space` on a sub-node toggles the field value (or focuses the field, depending on its type) - `delete` on a sub-node reverts the field value to its default - `control(+shift)+tab` cycles through categories of same level - `alt+{home|end}` focuses first/last content panel control - `F6` switches focus between categories and content panel - `control+enter` validates the dialog, independantly of wheither the currently focused control handles `enter` in some way - GUI: Criteria Editor: Rename the Criteria Set name field for easier UI discovery (#24) - GUI: Criteria Editor: Fix Criteria panel systematically exhibiting a horizontal scroll bar * GUI: GestureBinding: Don't send bare modifiers when capturing input Avoid triggering eg. Windows "Switch Keyboard Layout" shortcut when pressing `ctrl+shift`. - GUI: Avoid mistaking an unintentional `ValueError` for a meaningful `ValidationError` - GUI: MultiCategory editors: Select the invalid panel's category upon validation failure - Utils: `guarded` decorator: Add doc and forward decorated func's doc and name - Utils: Add `logException` decorator to help diagnose issues in property getters - GUI: guard more event handlers - GUI: Fix several scaling issues - GUI: Make `gui.ContextualSettingsPanel` properly support multiple inheritance from subclasses. - Document methods of `gui.ContextualSettingsPanel` and make it abstract - GUI: Added new `gui.SizeFrugalComboBox` which does not request for additional width to accommodate the content of its drop-down - GUI: Follow-up of NVDA #15121 - `gui.mainFrame._popupSettingsDialog` is deprecated as of NVDA 2023.2 - `gui.mainFrame.popupSettingsDialog` is now part of the public API - GUI: Remove backport of `SettingsPanelAccessible` from NVDA 2021.1 - GUI: Drop support for older wxPython that was required for NVDA < 2018.3 - GUI: Rules Manager: Migrate use of deprecated `wx.TreeCtrl.[Get|Set]ItemPyData` - NodeHandler: Fix mouse move in Python 3 - Python 3: Replace lengthy Python 2 `super` calls --------- Co-authored-by: Sendhil RANDON <[email protected]> Co-authored-by: BOUYSSOU Gatien <[email protected]> Co-authored-by: Julien Cochuyt <[email protected]>

- WebModule Editor: Do not require a trigger when creating from the Rule Editor - WebModule Manager: Add key shortcuts `F2`, `F3` and `delete` to edit, manage rules and delete, respectively (#38) - WebModule Manager: Set "no" as the default when prompting for deletion - Refactor `gui.actions` into `gui.rule.actions` - Refactor `gui.criteriaEditor` into `gui.rule.criteriaEditor` - Refactor `gui.gestureBinding` into `gui.rule.gestureBinding` - Refactor `gui.properties` into `gui.rule.properties` - Refactor `gui.webModulesManager` into `gui.webModule.manager` - Refactor `gui.webModuleEditor` into `gui.webModule.editor` - Refactor `gui.webModuleManager.promptDelete` into `gui.webModule.promptDelete` - GUI: Refactor `gui.webModuleManager.promptMask` into `gui.webModule.promptMask`

JulienCochuyt added the enhancement label Jul 22, 2024

JulienCochuyt changed the title ~~Rule Editor keyboard navigation~~ Rule Editor: Keyboard navigation Jul 22, 2024

JulienCochuyt added a commit that referenced this issue Aug 12, 2024

RuleEditor: Keyboard navigation (#38) - Follow-up

fd570b0

- `control+enter`: Validate the dialog, independantly of wheither the currently focused control handles `enter` in some way Follow-up of 7ba4e94

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rule Editor: Keyboard navigation #38

Rule Editor: Keyboard navigation #38

JulienCochuyt commented Jul 22, 2024

JulienCochuyt commented Aug 4, 2024 •

edited

Loading

Rule Editor: Keyboard navigation #38

Rule Editor: Keyboard navigation #38

Comments

JulienCochuyt commented Jul 22, 2024

JulienCochuyt commented Aug 4, 2024 • edited Loading

JulienCochuyt commented Aug 4, 2024 •

edited

Loading