Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: DNS based validation only success if ALL authorative DNS servers return the same (correct) challenge value #4863

Open
jahlives opened this issue Nov 8, 2023 · 1 comment

Comments

@jahlives
Copy link

jahlives commented Nov 8, 2023

We run into an issue today with DNS challenge validation. It seems that not all of our domains authoritative servers (3) received the TXT challenge in the same time (through zone update from our master DNS). This lead to the issue that the local challenge check, via system resolver returned all okay but when LetsEncrypt themselves validated the challenge they detected an issue. Debugging showed me that not all of our auth DNS servers got the same result at the same time. So highly possible LetsEncrypt (or better their resolvers) asked one of our auth server which did not have the challenge and our system resolver got the positive result from another of our auth server.

So we discussed this internally and thought that the following solution should mitigate this problem as best as possible: instead of asking the system resolver or any other resolver the acme.sh code could directly check ALL the domain's auth DNS and ONLY proceed if ALL of them return the same (correct) challenge result. Would something like that be accepted as feature request? Maybe an additional parameter for DNS challenge to use auth DNS instead of resolvers?

Copy link

github-actions bot commented Nov 8, 2023

Please upgrade to the latest code and try again first. Maybe it's already fixed. acme.sh --upgrade If it's still not working, please provide the log with --debug 2, otherwise, nobody can help you.

@jahlives jahlives changed the title DNS based validation only success if ALL authorative DNS servers return the same (correct) challenge value [Feature Request]: DNS based validation only success if ALL authorative DNS servers return the same (correct) challenge value Nov 8, 2023
@jahlives jahlives changed the title [Feature Request]: DNS based validation only success if ALL authorative DNS servers return the same (correct) challenge value [Feature]: DNS based validation only success if ALL authorative DNS servers return the same (correct) challenge value Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant