Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quoting fields when using writeCSV #176

Open
MMesch opened this issue Jul 11, 2023 · 1 comment
Open

Quoting fields when using writeCSV #176

MMesch opened this issue Jul 11, 2023 · 1 comment

Comments

@MMesch
Copy link

MMesch commented Jul 11, 2023

Hey, it seems writeCSV isn't quoting fields, even if writeDSV is used with ParserOptions that include quoting. Maybe something to add here: https://github.com/acowley/Frames/blob/master/src/Frames/ShowCSV.hs#L9-L11 ?

@MMesch
Copy link
Author

MMesch commented Jul 11, 2023

Investigating this a bit further I wonder why functions such as produceDSV use the showCSV instance instead of simply Show which seems to do quoting automatically 🤔 . writeFile "data.csv" $ showFrame "," frame seems to do exactly the right thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant