-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker latest
tag is deprecated and is being removed entirely
#2056
Comments
Is it possible to update the version of Node in the Base image - Snyk flagging up vulnerabilities in current base |
@gthomson31 Node.js isn't included in the base image by default, or are you referring to what's packaged with Ubuntu 20/22? Our team is using https://github.com/actions/setup-node to install whatever version is required by a workflow at exec time. That Action works in the rootless dind image, also. |
Yeah think it must be Ubuntu that its complaining about - its a strange error as even on investigating the image I couldn't see any mention of Node either so not sure why snyk scanning throws this up. |
It comes from the actions/runner software, you'd need to raise an issue in that repository |
Hey @toast-gear, I'm just curious what this means for RunnerDeployment defaults? If the |
Hi! We are using this image: summerwind/actions-runner:ubuntu-20.04 But it yields this warning when we execute the runner:
Is thisa as expected? This is not the 'latest' tag, but I suppose it's the latest runner software for ubuntu-20.04, so that we don't have to auto update it every time it boots.. but I am not sure this is a problem Thanks! |
@pimguilherme I am using |
thanks for the tip @DoNotResuscitate ! we are using this is the pod config basically:
thanks! |
@pimguilherme fwiw, it looks like this notice gets logged without any conditional check, so it seems like it's expected behavior to me: https://github.com/actions/actions-runner-controller/blob/master/runner/startup.sh#L176-L177 (I just noticed this warning after upgrading as well and did a little digging on it) |
@pimguilherme you asked the difference.
|
thanks @racker7 ! that is indeed an interesting tradeoff :) |
@toast-gear Please clear up a few things. Where is it documented that you can/should use the GHCR repo for images, and what tags you should use? I expected to find it in the README but I didn't find it there or in the docs. Which is the right URL to view the action-runner and action-runner-dind tags? https://github.com/actions/actions-runner-controller has a "Packages" link that goes to https://github.com/orgs/actions/packages?repo_name=actions-runner-controller that has an entry "actions-runner" that goes to https://github.com/actions/actions-runner-controller/pkgs/container/actions-runner-controller%2Factions-runner that has an outdated list of tags. The latest one is v2.299.1. Note that all of the above URLs are under the "actions" org. If I go to https://github.com/actions-runner-controller/actions-runner-controller (under the "actions-runner-controller" org) I get redirected to https://github.com/actions/actions-runner-controller (the "actions" org). However, if I go directly to https://github.com/actions-runner-controller/actions-runner-controller/pkgs/container/actions-runner-controller%2Factions-runner I see the latest tag isv2.303.0, which is the same latest tag I see at https://hub.docker.com/r/summerwind/actions-runner/tags I don't know why there are 2 GHCR package orgs or why the latest runner images are published under the old org ("actions-runner-controller", which redirects to "actions"). It is very confusing and it makes the right image hard to find. I also don't know where to find the source or release notes for |
oh damn I just ran into that @Nuru super confusing |
Came here from the warning in the logs of my action runners. I've found the warning is shown on all images, as the code does not check if we're using the latest image or not actions-runner-controller/runner/startup.sh Line 176 in d134dee
This is quite confusing since the warning is shown in capital letters as if it was super important (and it catches attention), whereas the issue is already solved if I've configured my runners to use a given distro image for example. Could we find a way to hide this warning on non-
Regarding images to use, after finding the build pipeline, I'm happy to confirm images are published to GHCR and the docker hub, here are links to their repos
|
@TPXP Thanks for the list. Currently, https://ghcr.io/actions-runner-controller/actions-runner-controller/actions-runner-controller does not work. For some reason, it redirects to: which does not exist. It appears the correct URL for actions-runner-controller is https://ghcr.io/actions-runner-controller/actions-runner-controller |
The `latest` tag of `summerwind/actions-runner` is now deprecated, so this patch switches over to the 22.04 tag. Related issue: actions/actions-runner-controller#2056
@toast-gear I was just wondering if there was any update on this? It still seems unclear which images we're supposed to use. |
Furthermore, the chart docs point also to the wrong images in them. https://github.com/actions/actions-runner-controller/blob/master/charts/gha-runner-scale-set/values.yaml#L123 |
@pecigonzalo That's a different chart for a different runner, so naturally it points to a different image. The project has split into GitHub-supported Of course, @toast-gear, this only further confuses things, not only because we now have to keep track of two separate but closely linked and similarly named projects, but because the official chart uses the "latest" tag which you say is deprecated. |
@Nuru I don't think that is that obvious or natural given the comments here, and the image could have been compatible with both versions as well. I actually would have expected that to be the case, that both charts use the same images with different flags. Given the unclear docs, it was a bit hard to find the right |
We are deprecating the
latest
tag and subsequently removing it from DockerHub. Please adjust your environment to use the OS specific latest image.Rationale
We are introducing a second runner image based on 22.04. This creates maintaining a
latest
tag difficult as it means having to switch over OS versions at essentially a random time potentially breaking users environments. Instead we will maintain a latest image on a per OS basis so end users can switch over to the newer image in their own time in a controlled manner.The text was updated successfully, but these errors were encountered: