From d57789bd755a481956ce43271807efcc4a88768d Mon Sep 17 00:00:00 2001 From: Federico Date: Tue, 7 Jan 2025 12:00:31 +1100 Subject: [PATCH 1/2] fix: hardcoded namespace --- .github/actions/execute-assert-arc-e2e/action.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/actions/execute-assert-arc-e2e/action.yaml b/.github/actions/execute-assert-arc-e2e/action.yaml index 872d02d924..d89f452050 100644 --- a/.github/actions/execute-assert-arc-e2e/action.yaml +++ b/.github/actions/execute-assert-arc-e2e/action.yaml @@ -192,7 +192,7 @@ runs: shell: bash if: always() run: | - LISTENER_POD="$(kubectl get autoscalinglisteners.actions.github.com -n arc-systems -o jsonpath='{.items[*].metadata.name}')" + LISTENER_POD="$(kubectl get autoscalinglisteners.actions.github.com -n ${{inputs.arc-controller-namespace}} -o jsonpath='{.items[*].metadata.name}')" kubectl logs $LISTENER_POD -n ${{inputs.arc-controller-namespace}} - name: Gather coredns logs @@ -212,4 +212,4 @@ runs: shell: bash if: always() run: | - kubectl logs deployment/arc-gha-rs-controller -n ${{inputs.arc-controller-namespace}} \ No newline at end of file + kubectl logs deployment/arc-gha-rs-controller -n ${{inputs.arc-controller-namespace}} From d6670c274d71ad6f010b2b2a9b16e3bf8cd1e6c5 Mon Sep 17 00:00:00 2001 From: Federico Date: Tue, 7 Jan 2025 13:13:51 +1100 Subject: [PATCH 2/2] fix: improve logic to support multiple listener pods --- .github/actions/execute-assert-arc-e2e/action.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/actions/execute-assert-arc-e2e/action.yaml b/.github/actions/execute-assert-arc-e2e/action.yaml index d89f452050..a0dba89a02 100644 --- a/.github/actions/execute-assert-arc-e2e/action.yaml +++ b/.github/actions/execute-assert-arc-e2e/action.yaml @@ -192,8 +192,11 @@ runs: shell: bash if: always() run: | - LISTENER_POD="$(kubectl get autoscalinglisteners.actions.github.com -n ${{inputs.arc-controller-namespace}} -o jsonpath='{.items[*].metadata.name}')" - kubectl logs $LISTENER_POD -n ${{inputs.arc-controller-namespace}} + for i in $(kubectl get autoscalinglisteners.actions.github.com -n ${{inputs.arc-controller-namespace}} -o jsonpath='{.items[*].metadata.name}'); do + echo "===== Logs for pod: $i =====" + kubectl logs $i --prefix -n ${{inputs.arc-controller-namespace}} + echo "" + done - name: Gather coredns logs shell: bash