-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE] MG5 EU Exterior Temperature generic check causes integration to go unavailable #79
Comments
Hi @madhulk81 Thabks for pointing that out and for letting me know about this. Do you have a log for your MG5, so I may see the kind of vehicle response and vehicle info for that model? That might help on setting up the checks or on how to find a way to address it. Cheers |
Hope this is helpful: 2024-12-29 12:56:26.844 DEBUG (MainThread) [custom_components.mg_saic] No changes detected in monitored keys or charging status. |
Thanks @madhulk81 I did not think of that to be honest. I thought that you could get the data for every vehicle. Looking at your logs, though, seems like you are getting generic responses for both temperature sensors:
So even if I get rid of the |
Anyhow, I removed that check for next release. |
Thanks @ad-ha Just to let you know - for the MG5 exteriorTemperature never works - always returns -128. The log I sent you showed internet as -128, but does work intermittently, depending on the API's mood :) Therefore, if you do plan on checking vehicle type, or checking these values, then interior will work sometimes, but external will never work. Thanks again! |
Home Assistant Version
2024.12.4
MG/SAIC Integration Version
0.8.2
Installation Method
HACS
Did you check for existing issues?
Did you enable debug logging before and are ready to post logs?
Describe the Issue
The check for generic data on the ExternalTemperature returned data causes the integration to report unavailable for most of the sensors. I don't think that the MG5 has external temp reported via the API (iSmart does not display it, only internal) so the test for generic data always fails, causing the tool to give up and not display the remaining data.
Removing the external check from coordinator.py solves the issue, so it might require a vehicle type check?
Many thanks for the work in the integration - it otherwise works really well!
Alex
Logs
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: