Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

screen reader should read out aria-labelledby/label to be consistent with latest slider #112

Closed
joe-allen-89 opened this issue Jul 12, 2024 · 0 comments · Fixed by #113
Closed

screen reader should read out aria-labelledby/label to be consistent with latest slider #112

joe-allen-89 opened this issue Jul 12, 2024 · 0 comments · Fixed by #113
Assignees
@joe-allen-89
Labels
accessibility bug

Comments

@joe-allen-89
Copy link
Contributor

Subject of the issue/enhancement/features

To be consistent with the slider reading out the header/ariaQuestion when tabbing through the screen we should add role="region" to component__widget

ref:
adaptlearning/adapt-contrib-slider#210

Your environment

  • FW v5.40.3
  • Latest Firefox
  • Windows, NVDA
@joe-allen-89 joe-allen-89 self-assigned this Jul 12, 2024
@joe-allen-89 joe-allen-89 moved this from New to Assigned in adapt_framework: The TODO Board Jul 12, 2024
joe-allen-89 added a commit that referenced this issue Jul 12, 2024
@joe-allen-89
Fix: role added to component__widget div (#112)
e4dc878
@joe-allen-89 joe-allen-89 mentioned this issue Jul 12, 2024
Merged
@joe-allen-89 joe-allen-89 linked a pull request Jul 12, 2024 that will close this issue
Fix: role added to component__widget div (fixes #112) #113
Merged
@joe-allen-89 joe-allen-89 moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Jul 12, 2024
joe-allen-89 added a commit that referenced this issue Jul 18, 2024
@joe-allen-89
Fix: role added to component__widget div (fixes #112) (#113)
4244c1c 
* Fix: role added to component__widget div (#112)

* role updated from region to group.
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Jul 18, 2024
github-actions bot pushed a commit that referenced this issue Jul 18, 2024
@semantic-release-bot
Chore(release): 5.5.3 [skip ci]
cd39aad 
## [5.5.3](v5.5.2...v5.5.3) (2024-07-18)

### Fix

* role added to component__widget div (fixes #112) (#113) ([4244c1c](4244c1c)), closes [#112](#112) [#113](#113) [#112](#112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joe-allen-89 joe-allen-89

Labels
accessibility bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: role added to component__widget div (fixes #112) adaptlearning/adapt-contrib-confidenceSlider
1 participant
@joe-allen-89