Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inview throws error when no element passed #598

Closed
oliverfoster opened this issue Oct 23, 2024 · 0 comments · Fixed by #599
Closed

Inview throws error when no element passed #598

oliverfoster opened this issue Oct 23, 2024 · 0 comments · Fixed by #599
Assignees
@oliverfoster
Labels
bug Something isn't working

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Oct 23, 2024 •
edited
Loading

Subject of the issue

$([]).onscreen() will error, it should return undefined. It is currently preventing bookmarking from returning users to their previous page due to this line https://github.com/adaptlearning/adapt-contrib-bookmarking/blob/f3c95c09426bfa330a687a36883974b20b31db03/js/adapt-contrib-bookmarking.js#L144
@oliverfoster oliverfoster added the bug Something isn't working label Oct 23, 2024
@oliverfoster oliverfoster self-assigned this Oct 23, 2024
oliverfoster added a commit that referenced this issue Oct 23, 2024
@oliverfoster
Fix: inview return undefined when no element supplied (fixes #598)
6522bd9
@oliverfoster oliverfoster mentioned this issue Oct 23, 2024
Merged
@oliverfoster oliverfoster moved this from New to Needs Reviewing in adapt_framework: The TODO Board Oct 23, 2024
oliverfoster added a commit that referenced this issue Oct 28, 2024
@oliverfoster
Fix: inview return undefined when no element supplied (fixes #598) (#599
292a1a8 
)
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Oct 28, 2024
github-actions bot pushed a commit that referenced this issue Oct 28, 2024
@semantic-release-bot
Chore(release): 6.60.1
89a0421 
## [6.60.1](v6.60.0...v6.60.1) (2024-10-28)

### Fix

* inview reprocess on window resize (fixes #596) (#597) ([151079f](151079f)), closes [#596](#596) [#597](#597)
* inview return undefined when no element supplied (fixes #598) (#599) ([292a1a8](292a1a8)), closes [#598](#598) [#599](#599)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverfoster oliverfoster

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: inview return undefined when no element supplied (fixes #598) adaptlearning/adapt-contrib-core
1 participant
@oliverfoster