Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update _target in example.json as per schema requirements #99

Closed
chris-steele opened this issue Apr 3, 2024 · 1 comment · Fixed by #100
Closed

Update _target in example.json as per schema requirements #99

chris-steele opened this issue Apr 3, 2024 · 1 comment · Fixed by #100
Assignees
@swashbuck
Labels
bug released

Comments

@chris-steele
Copy link

Subject of the issue

Schema requires _target to have value of "_blank", "_self", "_parent", or "_top". If example.json is used and subsequently imported into the Adapt Authoring Tool data validation fails.

Expected behaviour

Schema default is "_blank" so this should be reflected in example.json.
@swashbuck swashbuck self-assigned this May 29, 2024
@swashbuck swashbuck moved this from New to Assigned in adapt_framework: The TODO Board May 29, 2024
@swashbuck swashbuck mentioned this issue May 29, 2024
Merged
@swashbuck swashbuck moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board May 29, 2024
swashbuck added a commit that referenced this issue Jun 3, 2024
@swashbuck
Fix: Add default value for _target (fixes #99)
9af4644
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Jun 3, 2024
github-actions bot pushed a commit that referenced this issue Jun 3, 2024
@semantic-release-bot
Chore(release): 6.2.5 [skip ci]
5c95298 
## [6.2.5](v6.2.4...v6.2.5) (2024-06-03)

### Fix

* Add default value for _target (fixes #99) ([9af4644](9af4644)), closes [#99](#99)
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

🎉 This issue has been resolved in version 6.2.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Add default value for _target (fixes #99) adaptlearning/adapt-contrib-graphic
2 participants
@swashbuck @chris-steele