Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce duplicate code across plugins using notify popup #275

Closed
kirsty-hames opened this issue May 24, 2023 · 1 comment
Closed

Reduce duplicate code across plugins using notify popup #275

kirsty-hames opened this issue May 24, 2023 · 1 comment
Assignees

Comments

@kirsty-hames
Copy link
Contributor

Subject of the enhancement

As per adaptlearning/adapt-contrib-vanilla#443, the default style for Notify icon buttons is consistent across all plugins however we've duplicated the styling code across the various plugin LESS files in Vanilla.

See Hotgraphic close button in comparison to core Notify close button. The CSS being applied is the same but attached to different selectors.

notify_close_btn

Hotgraphic targets .hotgraphic-popup__controls and .hotgraphic-popup__close

Suggest applying .notify__btn-icon to inherit from Vanilla notify.less and remove the duplicate code from Vanilla hotgraphicPopup.less. This means the default style is set in one place but we still have plugin specific classes to target should you want to style these different - although there's good reason for keeping UI button styling consistent.

@kirsty-hames
Copy link
Contributor Author

To be resolved in Vanilla as per adaptlearning/adapt-contrib-vanilla#443 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant