Reduce duplicate code across plugins using notify popup #95
Assignees
Labels
Comments
kirsty-hames
moved this from Assigned
to Needs Reviewing
in adapt_framework: The TODO Board
oliverfoster
moved this from Needs Reviewing
to Assigned
in adapt_framework: The TODO Board
|
To be resolved in Vanilla as per adaptlearning/adapt-contrib-vanilla#443 (comment) |
github-project-automation
bot
moved this from Assigned
to Recently Released
in adapt_framework: The TODO Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Subject of the enhancement
As per adaptlearning/adapt-contrib-vanilla#443, the default style for Notify icon buttons is consistent across all plugins however we've duplicated the styling code across the various plugin LESS files in Vanilla.
Suggest applying
.notify__btn-iconto.tutor__btn-iconso styles inherit from Vanilla notify.less and remove the duplicate code from Vanilla tutor.less. This means the default style is set in one place but we still have plugin specific classes to target should you want to style these different - although there's good reason for keeping UI button styling consistent.The text was updated successfully, but these errors were encountered: