New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix actions with on* (eg onBlur) #7

Closed

patrick-emmanuel opened this issue Jan 30, 2020 · 0 comments

Labels

good first issue

Collaborator

patrick-emmanuel commented Jan 30, 2020

It would be more idiomatic if the actions would be all prefixed with on*. For example: onBlur onChange, onComplete etc.

It is also confusing because of ember's component events names in the component class: https://guides.emberjs.com/release/components/handling-events/#toc_event-names

Migrated from: code-corps/ember-stripe-elements#55

st-h added the good first issue label

patrick-emmanuel mentioned this issue

Prefix actions with on* (eg onBlur) #12

Merged

st-h closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment