Extend Functionality for Dynamically Fetching HW Specific Environment Variables

[piyush286]

Problem Description

For running any benchmark, we need to fetch the HW specific variables that change depending on the machine selected. We also populate these HW specific variables on PerfNext GUI, as shown below in the screenshot, so that users are able to change the affinity and other commands if needed.

Currently, environment variables are hard-coded for just one machine right now. So, you would need to manually change environment variables such as CLIENT, DB_MACHINE, LIBERTY_HOST and AFFINITY while running some benchmarks, especially the ones that require more than one machine, such as Liberty DayTrader.

One example of hard-coded configs:
https://github.com/AdoptOpenJDK/openjdk-test-tools/blob/b528a63ea146080f4bb1430740a734c2af87df7e/PerfNext/config/benchmarks/data_simple/Liberty.xml#L18-L31

Proposed Solution

Task 1:

We should remove all machine specific environment variables from the various XML configs files under PerfNext/config/benchmarks/data_simple since they are already present in the /config/master_machine_list.xml, which has all the machine specific configs, a file that the user provides while deploying PerfNext.

Snippet from master_machine_list.xml

                    <capability id="41" name="LibertyDayTrader" bits="all">
                        <property id="1" name="client">perfxposh10G</property>
                        <property id="2" name="dbMachine">perfxposh10G</property>
                        <property id="3" name="dbHome">/home/db2inst1/</property>
                        <property id="4" name="dbName">day30r</property>
                        <property id="5" name="dbUserName">db2inst1</property>
                        <property id="6" name="appServer">DayTrader3</property>
                        <property id="7" name="dbPort">50000</property>
                        <property id="8" name="libertyPort">9080</property>
                        <property id="9" name="scriptName">tradelite.sh</property>
                        <property id="10" name="clientWorkDir">/java/perffarm/liberty</property>
                        <property id="11" name="libertyHost">kermit10G</property>
                    </capability>

Task 2:

While PerfNext was being developed internally, I had already added majority of the functionality for fetching HW specific environment variables such as CPU Affinity variables by coding various functions (shown below) for it in PerfNext/public/lib/js/util.js. We need extend this functionality to fetch other HW specific environment variables that might be missing.

Snippet Code from PerfNext/public/lib/js/util.js:
https://github.com/AdoptOpenJDK/openjdk-test-tools/blob/b528a63ea146080f4bb1430740a734c2af87df7e/PerfNext/public/lib/js/util.js#L423-L635

Assigned Contributors

Awsaf (@pinicman) from my team would work on adding this functionality.

[smlambert]

related https://github.com/AdoptOpenJDK/openjdk-jenkins-helper

[piyush286]

Related to this issue Store HW Specific Benchmark Variables for Perf Testing. I thought it might be more appropriate to open a separate issue for that since that would require some additional work.

[smlambert]

Note: we have very recently added the ability to query machine information into the base of testkitgen (a.k.a. Openjdk-tests framework), see https://github.com/eclipse/openj9/tree/master/test/TestConfig/src/org/openj9/envInfo

This may be more useful and suitable to augment for gathering additional machine/hw info, and generating a machine info file needed by perf tests.

[piyush286]

Thanks @smlambert for sharing that info. We can discuss this in our PerfNext meeting tmr.