-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track all test materials or frameworks sha info #5818
Comments
Draft: functional.dev https://ci.adoptium.net/view/Test_grinder/job/Grinder/12068/ |
@smlambert thoughts? |
github-project-automation
bot
moved this from In Progress
to Done
in 2024 4Q Adoptium Plan
Jan 23, 2025
This was referenced Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Part of #5759
Currently some repos ( TKG, openj9, aqa-tests and/or vendors shas) are checked by get.sh (https://github.com/search?q=repo%3Aadoptium%2Faqa-tests%20checkRepoSHA&type=code, which calls getSHA.sh in TKG), as those repos are visible when the get.sh is called.
Some repos are checked per test in build.xml (https://github.com/search?q=repo%3Aadoptium%2Faqa-tests+checkGitRepoSha&type=code, which calls macrodef in TKG, and then getSHA.sh in TKG)
Some repos sha are not checked and hence are missing in tap file. We could update each test build.xml as https://github.com/search?q=repo%3Aadoptium%2Faqa-tests+checkGitRepoSha&type=code. Though the solution feels more complicated when new tests material added. The collecting process is scattered across different places and different repo with each test needing to make the call. This approach is cumbersome and prone to being overlooked.
Suggestion to centralize the management of this process with the TKG framework can make it simpler and more convenient. Similar to testResultSummary, we can add a shaInfo target. This way collecting shas is invisible to aqa-tests hence no tests need to handle this itself.
The text was updated successfully, but these errors were encountered: