Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Daily Slack EA status to report published EA Test job failure & testcase stats #1182

Merged
merged 28 commits into from
Feb 5, 2025

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Feb 3, 2025

  • Make the published EA build status also report "AQA test failures: TestJobs=N/Tot TestTargets=N/Tot."
    To highlight need to fix/exclude to failures.
  • Also correct reproducibility% status which is currently incorrectly reporting and not finding the relevant reproducible build test

Example output: https://adoptium.slack.com/archives/C09NW3L2J/p1738669436392289

@andrew-m-leonard andrew-m-leonard self-assigned this Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@github-actions github-actions bot added code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts testing labels Feb 3, 2025
@smlambert
Copy link
Contributor

I have not looked at it closely, but want to make sure we are using correct nomenclature, if you are pulling info from TRSS, you are likely pulling test target information, not testcase information, will look more closely when back at my desk

@andrew-m-leonard
Copy link
Contributor Author

I have not looked at it closely, but want to make sure we are using correct nomenclature, if you are pulling info from TRSS, you are likely pulling test target information, not testcase information, will look more closely when back at my desk

Yes you're right, i'll change text to "TestTarget"

@andrew-m-leonard
Copy link
Contributor Author

I have not looked at it closely, but want to make sure we are using correct nomenclature, if you are pulling info from TRSS, you are likely pulling test target information, not testcase information, will look more closely when back at my desk

That terminology has been wrong for a while... i've corrected all the existing instances too.

@karianna karianna requested a review from smlambert February 3, 2025 21:10
@andrew-m-leonard andrew-m-leonard requested review from smlambert and removed request for smlambert February 4, 2025 13:06
@andrew-m-leonard
Copy link
Contributor Author

@smlambert I've ended up fixing quite a bit in this PR with some re-factoring!, including the reproducibility% which was incorrectly searching for the ReproducibilityTest hence why it was not reporting anything...
If you could specifically review these sections please:

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smlambert smlambert merged commit 16e428f into adoptium:master Feb 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts testing
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants