Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Move from Annotations to CRD #51

Closed
adyanth opened this issue Mar 27, 2022 · 1 comment · Fixed by #63
Closed

Proposal: Move from Annotations to CRD #51

adyanth opened this issue Mar 27, 2022 · 1 comment · Fixed by #63
Labels
enhancement New feature or request help wanted Extra attention is needed roadmap Roadmap Item

Comments

@adyanth
Copy link
Owner

adyanth commented Mar 27, 2022

Motivation

Manage Cloudflare configuration outside the service lifecycle.

Current Status

Currently, the service is annotated with several annotations that determine the behaviour of the Service Controller. The controller adds a finalizer to the service preventing it from being deleted until the DNS records are deleted. If #43 is to be implemented, a new set of annotations come in, making it difficult to track all the possibilities.

Implementation

Create a CRD (ServiceTunnel? TunnelBinding like RoleBinding?) that binds the service and the tunnel to be served from. All configurations can be optional fields in the CRD. Finalizers can be on the CRD rather than the service, with an optional service finalizer to prevent deletion. For #43, a CRD (AccessTunnel) can be created that binds the referred service to the generated deployment.

@adyanth adyanth added enhancement New feature or request help wanted Extra attention is needed roadmap Roadmap Item labels Mar 27, 2022
@adyanth adyanth pinned this issue Mar 27, 2022
@adyanth
Copy link
Owner Author

adyanth commented May 11, 2022

This will also help to link the Tunnel to an existing service like the Ingress Controller's service. Also, when Load Balancer support is added, it will make adding it simple by inserting it right into the CRD.

#1 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed roadmap Roadmap Item
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant