Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converge with aeolus dev dependencies #1

Open
ifarkas opened this issue Nov 9, 2012 · 2 comments
Open

Converge with aeolus dev dependencies #1

ifarkas opened this issue Nov 9, 2012 · 2 comments

Comments

@ifarkas
Copy link

ifarkas commented Nov 9, 2012

Dev-tools supports rbenv while Conductor uses rvm. Both tools have the same purpose and I think we should use only one of them in all Aeolus subprojects.

@jguiditta
Copy link
Member

I can't see that happening, as people who use each tool feel strongly about their choice. Further, I don't think there is any reason they have to be mutually exclusive. Each tool is only going to use its own config file, but I agree that we should not have rvm in one place and rbenv in another. Really, if anything, I think this issue should become a request for rvm support (which I would fully back), especially since it is already used in both conductor and tim (and alberich, I believe).

@cwolferh
Copy link
Contributor

cwolferh commented Nov 9, 2012

To clarify a bit, when dev-tools sets up the development environment for Conductor (with system ruby or rbenv), it relies on bundler and Conductor's Gemfile to install gem dependencies. So, the user should still be getting a proper development environment per se.

If someone wants to add rvm support to dev-tools, I would support that too. Not being a big rvm user, I assume it would feasible to do that in the existing bootstrap.sh (sidebar: whether this should be broken up into multiple scripts is another issue) by looking for a environment variable like RVM_VERSION much as the current script has support for RBENV_VERSION. The current script has the philosophy of not mucking with the user's default shell functions / environment variables and I'm not sure that would be the case anymore if we added rvm support, but I'll defer to the rvm experts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants