Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report [BUG] about tutorial #186

Open
Keep-Raining opened this issue Nov 5, 2024 · 1 comment
Open

Bug report [BUG] about tutorial #186

Keep-Raining opened this issue Nov 5, 2024 · 1 comment

Comments

@Keep-Raining
Copy link

Describe the bug
/src/pycisTopic/gene_annotation.py, line 668
/src/pycisTopic/cli/subcommand/qc.py, line 212, 219: there is no parameter 'has_header', I think it should be 'include_header'.

and /src/pycisTopic/cli/subcommand/qc.py, line 498, the CB column is mistakenly named as 'by'.

To Reproduce
Follow the tutorial
https://pycistopic.readthedocs.io/en/latest/notebooks/human_cerebellum.html#QC: Cell17 and Cell24

https://pycistopic.readthedocs.io/en/latest/notebooks/human_cerebellum.html#QC: Cell24

@ghuls
Copy link
Member

ghuls commented Nov 6, 2024

The Polars_1xx branch should have this fixes (and a lot of other Polars syntax updates: https://github.com/aertslab/pycisTopic/tree/polars_1xx

9892252
ca9b230

Tutorials still need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants