Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in demo #1

Open
snippler opened this issue Nov 7, 2022 · 3 comments
Open

Bug in demo #1

snippler opened this issue Nov 7, 2022 · 3 comments

Comments

@snippler
Copy link

snippler commented Nov 7, 2022

Get this error when I run the demo:

UnboundLocalError: local variable 'v_shaped' referenced before assignment

This is in lib/python3.9/site-packages/supr/pytorch/supr.py

@NeelayS
Copy link

NeelayS commented Nov 15, 2022

Hi @snippler, if you change lines 80 and 81 in supr/pytorch/supr.py to the following and re-install, it'll solve the error.

num_verts = v_template.shape[1]
batch_size = v_template.shape[0]

@BotScutters
Copy link

Hi @NeelayS, I'm glad to see you responded to this, as I was recently running into this as well. Are there plans to make a PR to fix this, or make any other improvements to the code? This might belong in a new issue, but I've been reading through the code in preparation for a future project and really wishing there was a bit better documentation of what's happening in the code, particularly in the forward method of supr.py. In particular, can you provide clearer definitions of the types and structures of inputs and outputs, both in the docstring and maybe through inline comments as well? As the code is now, return v is really quite opaque and requires a user to really sift through everything that's happening in the forward pass to understand what the outputs are. Thanks!

@snippler
Copy link
Author

@NeelayS thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants