Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit in aiida-core>1.0.0b breaks CryPropertiesWorkChain.define #28

Open
chrisjsewell opened this issue Oct 23, 2019 · 0 comments
Open

Commit in aiida-core>1.0.0b breaks CryPropertiesWorkChain.define #28

chrisjsewell opened this issue Oct 23, 2019 · 0 comments

Comments

@chrisjsewell
Copy link
Member

aiidateam/aiida-core@9ebb8cc introduces a validator for the whole CalcJob namespace, which cross validates against inputs['code'], inputs['metadada.computer'] and inputs['metadada.resources'].

This change breaks the current tests for CryPropertiesWorkChain, within which optional calculation inputs are exposed: https://github.com/chrisjsewell/aiida-crystal17/blob/1eab9635e81a29956b0113bc91e13d5a4ee4269d/aiida_crystal17/workflows/crystal_props/base.py#L123

This issue is discussed in aiidateam/aiida-core#3449, aiidateam/aiida-core#3431, aiidateam/aiida-quantumespresso#418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisjsewell