Support AiiDA v2.6 - take 2 #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 92.71% 92.82% +0.11%
==========================================
Files 9 9
Lines 453 460 +7
==========================================
+ Hits 420 427 +7
Misses 33 33 ☔ View full report in Codecov by Sentry. |
|
@PhilippRue I think I've finally figured out how tu support AiiDA v2.6. It would be great if you could test this branch in your test suite, both with aiida 2.6 and (at least one) earlier version. Thanks! |
Closed
danielhollas
commented
Jan 13, 2025
| @@ -269,7 +269,7 @@ def mock_objects_to_hash_calcjob(self): | |||
| if key not in self._hash_ignored_attributes and key not in self._updatable_attributes | |||
| }, | |||
| { | |||
| entry.link_label: entry.node.base.caching.get_hash() | |||
| entry.link_label: entry.node.base.caching.compute_hash() | |||
There was a problem hiding this comment.
This is due to aiidateam/aiida-core#6347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant aiida-core changes / PRs:
get_hashtocompute_hashaiida-core#6347CACHE_VERSIONattribute toCalcJobandParseraiida-core#6328NodeCaching._get_objects_to_hashreturn type todictaiida-core#6323Partly addresses #71. Closes #80