exclude certain URLs from checking

[rdmueller]

in the same way in which I can configure which http codes are failure, warning and success, I would like to configure a list of URLs which are excluded from the http check:
(maybe as regexp)

httpExcludeURLs = [ '(http|https)://example.com.*']

[rdmueller]

I just noticed that there is already some kind of configuration for this

htmlSanityCheck/src/main/groovy/org/aim42/htmlsanitycheck/Configuration.groovy

Line 71 in 6dc5e59

final static String ITEM_NAME_urlsToExclude = "urlsToExclude"

but I can't find any implementation...

[Prankurtiwari]

Hi @ascheman I would like to work on this bug too, please assign this to me and let me know in case of any update update.

[ascheman]

@Prankurtiwari : The configuration has moved to htmlSanityCheck-core/src/main/java/org/aim42/htmlsanitycheck/Configuration.java as we switched from Groovy to Java meanwhile for the implementation of the core module.

[ascheman]

Perhaps @rdmueller could help elaborate on this?

Per my understanding, the Configuration should be extended by a Set<String> of URLs to ignore, for example as they require credentials. Perhaps it would make sense to enable some sort of pattern matching (regular expression) to allow to ignore a more or less large subset of URLs.

[elebeida]

Hi!

We have made a proposal for an implementation of this.

Is there any possibility to create a pull request for this and have someone review and assess if this is something that could be included in a future release? Or how does one proceed?

BR
Eleonor Bengtsson

[ascheman]

We have made a proposal for an implementation of this.

Thanks, sounds great.

Is there any possibility to create a pull request for this and have someone review and assess if this is something that could be included in a future release? Or how does one proceed?

Sure, did you fork the repository on GitHub? As soon as you push your changes, GH will ask whether you would like to create a PR against the upstream repository (cf. https://docs.github.com/en/pull-requests).

[elebeida]

ok, thank you