-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CommonJS and ESM lack appropriate extensions #41
Comments
Having the same issue - cannot use the library because it throws the above error |
I've tried fixing this in my fork. It would be great to know if it works. If someone can verify I'll open a PR. It's temporarily published on npm (scoped) |
I've tested this on my work SvelteKit TS 5.0 application and it's working perfectly. I'd previously had to set |
Using this library with vite and pre-render, produces the following error:
The reason is that both CommonJS and ESM exports are using the
.js
extension. Ifpackage.json#type
iscommonjs
(default),.js
can be used for CommonJS but.mjs
should be used for ESM. And ifpackage.json#type
ismodule
,.js
can be used for ESM output, but.cjs
should be used for CommonJS.I think
"type": "module"
is better because the.js
extension can be used for NodeJS modules and browsers alike, making mandatory.cjs
only for CommonJS files.The text was updated successfully, but these errors were encountered: