Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenApi3 and "application/json;charset=UTF-8" #8

Open
doktordirk opened this issue Jan 2, 2022 · 1 comment
Open

OpenApi3 and "application/json;charset=UTF-8" #8

doktordirk opened this issue Jan 2, 2022 · 1 comment

Comments

@doktordirk
Copy link

Thanks for you nice work!

We use application/json;charset=UTF-8 and not just application/json as it is assumed in types.d.ts and hence the response data type becomes unknown.

I wonder if it's possible to extend

Fetcher.for<paths>();
to optional
Fetcher.for<paths, 'application/json;charset=UTF-8'>();

and/or

fetcher.path('/xzy').method('get').create();
to optional
fetcher.path('/xyz').method<'application/json;charset=UTF-8'>('get').create();

@voxpelli
Copy link

JSON should always be utf-8 so specifying it as such is redundant. See eg: https://en.wikipedia.org/wiki/JSON#Character_encoding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants