Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement logger #71

Open
1 task
ygrishajev opened this issue Apr 1, 2024 · 2 comments · May be fixed by #102
Open
1 task

Implement logger #71

ygrishajev opened this issue Apr 1, 2024 · 2 comments · May be fixed by #102
Labels
kind/enhancement Enhance an existing feature/documentation

Comments

@ygrishajev
Copy link
Contributor

Currently project utilises nodejs console.log for logging with doesn't provide a desired observability or debugging experience. Some of the issues:

  1. noisy tests outputs
  2. no way to filter or identify logs by levels which complicates decision making
  3. logs are simple strings which would complicate indexing if stored in tools like kibana or grafana

A good way to address this would be having a proper logger having common features. One of the good ones is pino.

  • replace all the logs with a properly scoped pino logger
@github-project-automation github-project-automation bot moved this to Backlog (not prioritized) in Core Product and Engineering Roadmap Apr 17, 2024
@ygrishajev ygrishajev added the kind/enhancement Enhance an existing feature/documentation label Apr 17, 2024
jaseemuddinn added a commit to jaseemuddinn/akashjs that referenced this issue Oct 29, 2024
@jaseemuddinn
Implement logger
9e190c3 
Fixes akash-network#71

Replaced all `console.log` and `console.error` statements with pino logger statements.

* Imported pino and created a logger instance in `examples/create_deployment.ts`, `examples/details_of_single_provider.ts`, `examples/estimate_gas.ts`, `examples/get_deployments.ts`, `examples/get_lease_status.ts`, `examples/list_all_providers.ts`, `src/wallet/storage.ts`, `test.html`, and `tests/test_deployments.ts`.
* Replaced all `console.log` statements with `logger.info` in the above files.
* Replaced all `console.error` statements with `logger.error` in `examples/create_deployment.ts`.
@jaseemuddinn jaseemuddinn linked a pull request Oct 29, 2024 that will close this issue
Open
@github-project-automation github-project-automation bot moved this to Backlog (not prioritized) in Client Product and Engineering Roadmap Dec 13, 2024
@anilmurty anilmurty moved this from Backlog (not prioritized) to Up Next (prioritized) in Client Product and Engineering Roadmap Dec 13, 2024
@ygrishajev
Copy link
Contributor Author

After some thinking the better solution would be proper error/callbacks implementation. Logging shouldn't happen on lib level but implemented by the client code. @akash-network/console thoughts?

@baktun14
Copy link
Contributor

After some thinking the better solution would be proper error/callbacks implementation. Logging shouldn't happen on lib level but implemented by the client code. @akash-network/console thoughts?

Yes I agree

@anilmurty anilmurty moved this from Up Next (prioritized) to Backlog (not prioritized) in Client Product and Engineering Roadmap Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Enhance an existing feature/documentation
Projects
Client Product and Engineering Roadmap
Status: Backlog (not prioritized)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement logger jaseemuddinn/akashjs
2 participants
@ygrishajev @baktun14