From bad0e656ec00b5604c72cb01d9c9a3ff5f8a8159 Mon Sep 17 00:00:00 2001 From: Hidde Beydals Date: Tue, 10 Dec 2024 15:09:00 +0100 Subject: [PATCH] chore(directives): ensure stable order commit msg Signed-off-by: Hidde Beydals --- internal/directives/kustomize_image_setter.go | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/internal/directives/kustomize_image_setter.go b/internal/directives/kustomize_image_setter.go index b14b01b315..deb3c635aa 100644 --- a/internal/directives/kustomize_image_setter.go +++ b/internal/directives/kustomize_image_setter.go @@ -205,7 +205,17 @@ func (k *kustomizeImageSetter) generateCommitMessage(path string, images map[str } _, _ = commitMsg.WriteString("\n") - for _, i := range images { + // Sort the images by name, in descending order for consistency. + imageNames := make([]string, 0, len(images)) + for name := range images { + imageNames = append(imageNames, name) + } + slices.Sort(imageNames) + + // Append each image to the commit message. + for _, name := range imageNames { + i := images[name] + ref := i.Name if i.NewName != "" { ref = i.NewName