fix(controller): support parsing github enterprise urls #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kent Rancourt <[email protected]>
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2145 +/- ##
==========================================
+ Coverage 46.56% 46.59% +0.03%
==========================================
Files 239 239
Lines 16741 16745 +4
==========================================
+ Hits 7795 7803 +8
+ Misses 8573 8568 -5
- Partials 373 374 +1 ☔ View full report in Codecov by Sentry. |
hiddeco
reviewed
Jun 11, 2024
hiddeco
approved these changes
Jun 11, 2024
|
Feels like this could potentially be easily backported to 0.7.1? |
I wouldn't have done a v0.7.1 just for this, but since we're doing one for other reasons, I'm also inclined to include it. |
Signed-off-by: Kent Rancourt <[email protected]> Co-authored-by: Hidde Beydals <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
Signed-off-by: Kent Rancourt <[email protected]> Co-authored-by: Hidde Beydals <[email protected]> (cherry picked from commit 3bcbf42)
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2080