Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you release binding for v18.1.8 ? #19

Open
Kakadu opened this issue Aug 18, 2024 · 4 comments
Open

Could you release binding for v18.1.8 ? #19

Kakadu opened this issue Aug 18, 2024 · 4 comments

Comments

@Kakadu
Copy link

Kakadu commented Aug 18, 2024

I tried to do this myself but after ./setup.sh llvm-config-18 and dune b --profile=release I got an error. No idea how to proceed @alan-j-hu

➜  llvm-dune git:(v18.1.8) ✗ dune b --profile=release                                              
File "src/target/static/dune", line 8, characters 9-21:
8 |   (names target_ocaml)
             ^^^^^^^^^^^^
target_ocaml.c:18:10: fatal error: target_ocaml.h: No such file or directory
   18 | #include "target_ocaml.h"
      |          ^~~~~~~~~~~~~~~~
compilation terminated.
File "src/target/shared/dune", line 8, characters 9-21:
8 |   (names target_ocaml)
             ^^^^^^^^^^^^
target_ocaml.c:18:10: fatal error: target_ocaml.h: No such file or directory
   18 | #include "target_ocaml.h"
      |          ^~~~~~~~~~~~~~~~
compilation terminated.
➜  llvm-dune git:(v18.1.8) ✗ find . -iname target_ocaml.h                                                                                                    4.14.2+flambda
./_build/default/src/target/target_ocaml.h
./src/target/target_ocaml.h
./llvm-project/llvm/bindings/ocaml/target/target_ocaml.h
@alan-j-hu
Copy link
Owner

Sorry, I was trying to figure out how to do this after I released LLVM 17, but because of how some of the LLVM bindings source code is structured in LLVM 18, the Bash script has to be modified. IIRC this wasn't straightforward, and I need to take another look at it.

@lynzrand
Copy link

lynzrand commented Jan 3, 2025

Hi, I'm trying to work on this in my fork, including refactoring setup.sh into a more maintainable setup.py. I will make a PR once it's working.

As of the problem in this issue, I found that adding the corresponding C include directories (-I../ in src/target/shared/dune; -I../../../target in src/transform/passbuilder/shared/dune) fixes build errors. I will try to reflect this in my fork.

@alan-j-hu
Copy link
Owner

alan-j-hu commented Jan 3, 2025

Hi, I want to go back to the original packaging approach of building via LLVM's CMake build system. I have two PRs open for the next release at ocaml/opam-repository#27178 and ocaml/opam-source-archives#40.

However, the opam package repo maintainers have not interacted at all with my PRs. I figure it must be the holiday season and they must be resting, but if they don't respond in a while, I'll have to find a way to flag them down.

@Kakadu
Copy link
Author

Kakadu commented Jan 6, 2025

However, the opam package repo maintainers have not interacted at all with my PRs. I figure it must be the holiday season and they must be resting, but if they don't respond in a while, I'll have to find a way to flag them down.

Usually, I undraft the PR and write in the title 'READY FOR REVIEW'. @alan-j-hu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants