Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest commit introduces square checked artifacts in videos on linux odroid n2+ #136

Open
Kelvfimer opened this issue Mar 6, 2024 · 4 comments · May be fixed by #195
Open

Latest commit introduces square checked artifacts in videos on linux odroid n2+ #136

Kelvfimer opened this issue Mar 6, 2024 · 4 comments · May be fixed by #195

Comments

@Kelvfimer
Copy link

Hello

Issue

Building the latest commit ad8a275 when executing the game it is introducing checked squared artifacts in the videos.

Platform

Linux 4.9.269 #1 SMP PREEMPT Fri Feb 23 13:50:32 CET 2024 aarch64 GNU/Linux odroid n2 4GB

Latest working commit

ef27a64

Expected result

Video play as expected

Evidences or Examples

Fallour1videoartifact2
fallout1videoartifact

thx!!!
Kelvfimer referenced this issue Mar 7, 2024
@glebm
Fix some UB in movie_lib.cc (#117)
ad8a275
@KulikAlex
Copy link

You can fix it like this
KulikAlex@6f74011
What is wrong with getOffset?

@KulikAlex KulikAlex mentioned this issue Mar 8, 2024
Merged
Zenkibou added a commit to Zenkibou/fallout1-ce that referenced this issue Mar 23, 2024
@Zenkibou
Fix movie decoding
deb3f21 
Fixes regression from alexbatalov#117, see alexbatalov#136.
@glebm glebm linked a pull request Jun 9, 2024 that will close this issue
Open
@Izder456
Copy link
Contributor

Izder456 commented Dec 6, 2024 •
edited
Loading

Hello, this affects OpenBSD as well, on latest commit.

I'll try this PR patch and circle back.

Edit: @glebm's PR #195 fixes OpenBSD as well.

@Kelvfimer
Copy link
Author

@Izder456 cool I'll test I didn't notice hte PR. thx!!

@Kelvfimer
Copy link
Author

@Izder456 yes it fixes it :) @alexbatalov can you merge it? thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

movie_lib.cc: Fix incorrect return type of getOffset glebm/fallout1-ce
3 participants
@Izder456 @KulikAlex @Kelvfimer