Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DIEN implementation is not aligned with DIEN paper for some reason #103

Open
andrei-kochin opened this issue Jul 19, 2022 · 2 comments
Open

DIEN implementation is not aligned with DIEN paper for some reason #103

andrei-kochin opened this issue Jul 19, 2022 · 2 comments

Comments

@andrei-kochin
Copy link

andrei-kochin commented Jul 19, 2022 •
edited
Loading

Hello,

Could you please kindly clarify the reason in 'u_t' calculation in DIEN model?

ai-matrix/macro_benchmark/DIEN/script/utils.py

Line 217 in f7e1d77

u = (1.0 - att_score) * u

According to DIEN paper it should be u_t =a_t*u_t and in your implementation it is u_t = (1.0 - a_t) * u_t

Looking forward for your reply.

Thank you!
@jane-intel
Copy link

Paper: https://arxiv.org/pdf/1809.03672.pdf

Formulas 11-12:
image

@andrei-kochin
Copy link
Author

andrei-kochin commented Jul 19, 2022 •
edited
Loading

@rabbitwayne, @xulingjie @madeye @parallelo @ could you please help us to comment on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jane-intel @andrei-kochin