From cf17c73fe1c6e2914f5d799ee756a4d6934b72ee Mon Sep 17 00:00:00 2001 From: guyonroche Date: Tue, 16 May 2017 08:32:53 +0100 Subject: [PATCH] eslinting --- .eslintrc | 28 ++-- README.md | 4 +- lib/csv/csv.js | 2 +- lib/csv/stream-converter.js | 6 +- lib/doc/cell.js | 32 ++--- lib/doc/column.js | 29 ++--- lib/doc/defined-names.js | 13 +- lib/doc/range.js | 10 +- lib/doc/row.js | 34 ++--- lib/doc/workbook.js | 2 +- lib/doc/worksheet.js | 20 +-- lib/stream/xlsx/workbook-reader.js | 22 ++-- lib/stream/xlsx/workbook-writer.js | 2 +- lib/stream/xlsx/worksheet-reader.js | 8 +- lib/stream/xlsx/worksheet-writer.js | 8 +- lib/utils/cell-matrix.js | 7 +- lib/utils/col-cache.js | 11 +- lib/utils/flow-control.js | 3 +- lib/utils/shared-formula.js | 10 +- lib/utils/shared-strings.js | 2 +- lib/utils/stream-buf.js | 2 +- lib/utils/under-dash.js | 13 +- lib/utils/utils.js | 19 ++- lib/xlsx/defaultnumformats.js | 56 ++++---- lib/xlsx/xform/base-xform.js | 4 +- lib/xlsx/xform/book/defined-name-xform.js | 6 +- lib/xlsx/xform/book/workbook-xform.js | 8 +- lib/xlsx/xform/composite-xform.js | 8 +- lib/xlsx/xform/core/app-xform.js | 8 +- lib/xlsx/xform/core/content-types-xform.js | 22 ++-- lib/xlsx/xform/core/core-xform.js | 8 +- lib/xlsx/xform/core/relationship-xform.js | 2 +- lib/xlsx/xform/core/relationships-xform.js | 10 +- lib/xlsx/xform/drawing/blip-fill-xform.js | 2 +- lib/xlsx/xform/drawing/blip-xform.js | 2 +- lib/xlsx/xform/drawing/cell-position-xform.js | 2 +- lib/xlsx/xform/drawing/drawing-xform.js | 6 +- lib/xlsx/xform/drawing/pic-xform.js | 2 +- lib/xlsx/xform/drawing/sp-pr.js | 2 +- .../xform/drawing/two-cell-anchor-xform.js | 17 ++- lib/xlsx/xform/list-xform.js | 8 +- lib/xlsx/xform/sheet/auto-filter-xform.js | 2 +- lib/xlsx/xform/sheet/cell-xform.js | 6 +- .../xform/sheet/data-validations-xform.js | 10 +- lib/xlsx/xform/sheet/drawing-xform.js | 4 +- lib/xlsx/xform/sheet/hyperlink-xform.js | 2 +- lib/xlsx/xform/sheet/merges.js | 10 +- lib/xlsx/xform/sheet/page-margins-xform.js | 4 +- .../sheet/page-setup-properties-xform.js | 1 + lib/xlsx/xform/sheet/page-setup-xform.js | 10 +- lib/xlsx/xform/sheet/picture-xform.js | 4 +- lib/xlsx/xform/sheet/print-options-xform.js | 4 +- .../sheet/sheet-format-properties-xform.js | 2 +- .../xform/sheet/sheet-properties-xform.js | 3 +- lib/xlsx/xform/sheet/sheet-view-xform.js | 10 +- lib/xlsx/xform/sheet/worksheet-xform.js | 6 +- lib/xlsx/xform/simple/date-xform.js | 2 +- lib/xlsx/xform/static-xform.js | 4 +- lib/xlsx/xform/strings/phonetic-text-xform.js | 21 +-- lib/xlsx/xform/strings/rich-text-xform.js | 6 +- lib/xlsx/xform/strings/shared-string-xform.js | 2 +- .../xform/strings/shared-strings-xform.js | 4 +- lib/xlsx/xform/strings/text-xform.js | 2 +- lib/xlsx/xform/style/alignment-xform.js | 26 ++-- lib/xlsx/xform/style/border-xform.js | 4 +- lib/xlsx/xform/style/color-xform.js | 3 +- lib/xlsx/xform/style/fill-xform.js | 16 +-- lib/xlsx/xform/style/font-xform.js | 5 +- lib/xlsx/xform/style/numfmt-xform.js | 6 +- lib/xlsx/xform/style/styles-xform.js | 40 +++--- lib/xlsx/xform/style/underline-xform.js | 2 +- lib/xlsx/xlsx.js | 120 +++++++++--------- package.json | 6 +- spec/.eslintrc | 6 +- spec/browser/exceljs.spec.js | 2 +- spec/config/setup-unit.js | 5 + spec/end-to-end/express.spec.js | 9 +- .../issues/issue-219-1904-dates.spec.js | 4 +- .../issue-266-breaking-bluebird.spec.js | 22 ++-- .../issue-275-hyperlink-query-param.spec.js | 2 +- .../integration/issues/shared-formula.spec.js | 12 +- .../workbook-xlsx-writer.spec.js | 4 +- spec/integration/workbook/styles.spec.js | 2 +- spec/integration/workbook/workbook.spec.js | 34 ++--- .../integration/worksheet-xlsx-writer.spec.js | 32 ++--- spec/integration/worksheet.spec.js | 40 +++--- spec/manual/app.js | 2 +- spec/unit/doc/cell.spec.js | 18 +-- spec/unit/doc/column.spec.js | 18 +-- spec/unit/doc/defined-names.spec.js | 18 +-- spec/unit/doc/range.spec.js | 14 +- spec/unit/doc/row.spec.js | 72 +++++------ spec/unit/doc/workbook.spec.js | 18 +-- spec/unit/doc/worksheet-writer.spec.js | 3 +- spec/unit/doc/worksheet.merge.spec.js | 2 +- .../unit/doc/worksheet.shared-formula.spec.js | 8 +- spec/unit/doc/worksheet.values.spec.js | 42 +++--- spec/unit/utils/col-cache.spec.js | 22 ++-- spec/unit/utils/stream-buf.spec.js | 2 +- spec/unit/utils/string-buf.spec.js | 6 +- spec/unit/utils/xml-stream.spec.js | 4 +- .../xform/book/defined-name-xform.spec.js | 14 +- .../xform/book/workbook-view-xform.spec.js | 14 +- .../xlsx/xform/book/workbook-xform.spec.js | 4 +- .../core/app-heading-pairs-xform.spec.js | 8 +- .../core/app-titles-of-parts-xform.spec.js | 8 +- spec/unit/xlsx/xform/core/app-xform.spec.js | 8 +- .../xform/core/content-types-xform.spec.js | 10 +- spec/unit/xlsx/xform/core/core-xform.spec.js | 10 +- .../xform/core/relationships-xform.spec.js | 4 +- .../xlsx/xform/drawing/data/drawing.1.1.json | 2 +- .../xlsx/xform/drawing/data/drawing.1.2.xml | 4 +- .../xlsx/xform/drawing/data/drawing.1.3.json | 2 +- .../xlsx/xform/drawing/drawing-xform.spec.js | 2 +- spec/unit/xlsx/xform/list-xform.spec.js | 10 +- spec/unit/xlsx/xform/sheet/cell-xform.spec.js | 30 ++--- spec/unit/xlsx/xform/sheet/col-xform.spec.js | 6 +- .../sheet/data-validations-xform.spec.js | 10 +- .../xlsx/xform/sheet/dimension-xform.spec.js | 4 +- .../xlsx/xform/sheet/hyperlink-xform.spec.js | 4 +- .../xlsx/xform/sheet/merge-cell-xform.spec.js | 4 +- .../xform/sheet/page-margins-xform.spec.js | 4 +- .../xlsx/xform/sheet/page-setup-xform.spec.js | 23 +++- spec/unit/xlsx/xform/sheet/row-xform.spec.js | 26 ++-- .../sheet-format-properties-xform.spec.js | 2 +- .../sheet/sheet-properties-xform.spec.js | 8 +- .../xlsx/xform/sheet/sheet-view-xform.spec.js | 84 ++++++------ .../xlsx/xform/sheet/worksheet-xform.spec.js | 14 +- .../xlsx/xform/simple/boolean-xform.spec.js | 8 +- .../unit/xlsx/xform/simple/date-xform.spec.js | 19 +-- .../xlsx/xform/simple/float-xform.spec.js | 10 +- .../xlsx/xform/simple/integer-xform.spec.js | 8 +- .../xlsx/xform/simple/string-xform.spec.js | 8 +- spec/unit/xlsx/xform/static-xform.spec.js | 8 +- .../xform/strings/phonetic-text-xform.spec.js | 10 +- .../xform/strings/shared-string-xform.spec.js | 12 +- .../strings/shared-strings-xform.spec.js | 4 +- .../xlsx/xform/style/alignment-xform.spec.js | 42 +++--- .../xlsx/xform/style/border-xform.spec.js | 38 +++--- .../unit/xlsx/xform/style/color-xform.spec.js | 24 ++-- spec/unit/xlsx/xform/style/fill-xform.spec.js | 44 ++++--- spec/unit/xlsx/xform/style/font-xform.spec.js | 8 +- .../xlsx/xform/style/numfmt-xform.spec.js | 6 +- .../unit/xlsx/xform/style/style-xform.spec.js | 34 ++--- .../xlsx/xform/style/styles-xform.spec.js | 4 +- .../xlsx/xform/style/underline-xform.spec.js | 8 +- spec/unit/xlsx/xform/test-xform-helper.js | 26 ++-- spec/utils/index.js | 2 +- spec/utils/test-spliced-sheet.js | 80 ++++++------ spec/utils/test-values-sheet.js | 12 +- spec/utils/test-workbook-reader.js | 10 +- spec/utils/tools.js | 4 +- spec/utils/under-dash.js | 2 +- spec/utils/verquire.js | 2 +- test/testSax.js | 2 +- 155 files changed, 1009 insertions(+), 975 deletions(-) create mode 100644 spec/config/setup-unit.js diff --git a/.eslintrc b/.eslintrc index b2c97ae30..4f9f7c6b6 100644 --- a/.eslintrc +++ b/.eslintrc @@ -1,17 +1,23 @@ { "extends": "airbnb", "rules": { + "max-len": [1, 160, 2, {"ignoreComments": true}], + "semi": ["error", "always"], + "object-property-newline": ["off", { "allowMultiplePropertiesPerLine": true }], "func-names": ["off", "never"], + "space-before-function-paren": ["error", "never"], + "no-trailing-spaces": ["error", { "skipBlankLines": true }], + "no-mixed-operators": ["error", {"allowSamePrecedence": true}], "linebreak-style": ["off"], + "no-use-before-define": ["error", { "variables": false, "classes": false, "functions": false }], + "no-var": ["off"], "dot-notation": ["off"], "one-var": ["off"], - "no-mixed-operators": ["error", {"allowSamePrecedence": true}], "one-var-declaration-per-line": ["off"], "no-prototype-builtins": ["off"], "arrow-parens": ["off"], "quote-props": ["off"], - "no-use-before-define": ["off"], "no-underscore-dangle": ["off"], "vars-on-top": ["off"], "no-param-reassign": ["off"], @@ -26,25 +32,9 @@ "object-curly-spacing": ["off"], "no-plusplus": ["off"], "no-unused-expressions": ["off"], - "no-trailing-spaces": ["error", { "skipBlankLines": true }], "global-require": ["off"], - "no-sparse-arrays": ["off"], - "comma-spacing": ["off"], - "brace-style": ["off"], - "space-before-function-paren": ["off"], "no-unused-vars": ["off"], - "key-spacing": ["off"], - "object-property-newline": ["off"], - "block-spacing": ["off"], - "consistent-return": ["off"], - "keyword-spacing": ["off"], - "semi": ["off"], "no-path-concat": ["off"], - "prefer-rest-params": ["off"], - "max-len": [1, 160, 2, {"ignoreComments": true}] - }, - "globals": { - "describe": true, - "it": true + "prefer-rest-params": ["off"] } } \ No newline at end of file diff --git a/README.md b/README.md index 8e8307a83..024a2e11e 100644 --- a/README.md +++ b/README.md @@ -13,7 +13,8 @@ npm install exceljs