Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more informative logging to _request() method failures #3

Open
allardbrain opened this issue Apr 16, 2020 · 0 comments
Open

Add more informative logging to _request() method failures #3

allardbrain opened this issue Apr 16, 2020 · 0 comments
Labels
cleanup good first issue Good for newcomers

Comments

@allardbrain
Copy link
Owner

Let's try to provide as much relevant output via logging as possible for failed requests, such as:

  • response.status_code
  • response.content
  • response.json()
  • response.reason

Keep return response, though.
@allardbrain allardbrain self-assigned this Apr 16, 2020
@allardbrain allardbrain removed their assignment Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@allardbrain