Replies: 1 comment 1 reply
-
Alternatively, an errors library design could have been employed. An example can be found in Sablier's V2 Core repository. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Many custom errors, e.g.
UNAUTHORIZED
, are duplicated across multiple strategy contracts:allo-v2/contracts/strategies/direct-grants-simple/DirectGrantsSimpleStrategy.sol
Line 48 in 04f84f8
allo-v2/contracts/strategies/donation-voting/DonationVotingStrategy.sol
Line 46 in 04f84f8
Why are they not de-duplicated by defining them only in
BaseStrategy
?Beta Was this translation helpful? Give feedback.
All reactions